vektah / gqlparser

88%

master: 87%

LAST BUILD ON BRANCH fix/samevalue-composite-args

branch: fix/samevalue-composite-args

CHANGE BRANCH

x

Reset

• fix/samevalue-composite-args
• Fix-default-values-for-inline-input-object-fields-with-undefined-variables
• WrapIfUnwrapped
• add-schema-implements
• add_error_column
• allow-json-number
• arg2map
• build/migrate-yaml-v3-module
• check-for-self-referential-directives
• cleanup
• codex/fix-null-nested-list-coercion
• coerce-value
• coerce-variables
• colocate-spec
• consistent-collections
• default-var-value
• dependabot/github_actions/actions-deps-013bf0b14d
• dependabot/github_actions/actions-deps-06c47a9d96
• dependabot/github_actions/actions-deps-0d080bdfc2
• dependabot/github_actions/actions-deps-167a898cab
• dependabot/github_actions/actions-deps-262b37236a
• dependabot/github_actions/actions-deps-640176b5ab
• dependabot/github_actions/actions-deps-a331d3ec2d
• dependabot/github_actions/actions-deps-b5bd5a21f8
• dependabot/github_actions/actions-deps-c4cc0bb5e9
• dependabot/github_actions/actions-deps-ca90dd7130
• dependabot/github_actions/actions-deps-d3eb564edb
• dependabot/github_actions/actions-deps-e4eb14636d
• dependabot/github_actions/actions-deps-e986305a06
• dependabot/github_actions/actions-deps-ea00175525
• dependabot/github_actions/actions-deps-ea2f213dad
• dependabot/go_modules/actions-deps-37ff05d3c1
• dependabot/go_modules/actions-deps-55030fb405
• dependabot/go_modules/actions-deps-ddf553c9d0
• dependabot/go_modules/actions-deps-de845de4cf
• dependabot/go_modules/actions-deps-e0592cbbe8
• dependabot/npm_and_yarn/validator/imported/actions-deps-04c8951b36
• dependabot/npm_and_yarn/validator/imported/actions-deps-0ed3db9fe0
• dependabot/npm_and_yarn/validator/imported/actions-deps-1185a39f81
• dependabot/npm_and_yarn/validator/imported/actions-deps-14e12f3a00
• dependabot/npm_and_yarn/validator/imported/actions-deps-1875f92edc
• dependabot/npm_and_yarn/validator/imported/actions-deps-23fd34c2ce
• dependabot/npm_and_yarn/validator/imported/actions-deps-28c06f70cd
• dependabot/npm_and_yarn/validator/imported/actions-deps-2f07fc8f98
• dependabot/npm_and_yarn/validator/imported/actions-deps-30fa97e41a
• dependabot/npm_and_yarn/validator/imported/actions-deps-44683e7d6f
• dependabot/npm_and_yarn/validator/imported/actions-deps-482c5ae6e5
• dependabot/npm_and_yarn/validator/imported/actions-deps-4c2a62dc6d
• dependabot/npm_and_yarn/validator/imported/actions-deps-54e314b8ce
• dependabot/npm_and_yarn/validator/imported/actions-deps-5d3735b78c
• dependabot/npm_and_yarn/validator/imported/actions-deps-60f83fc3b8
• dependabot/npm_and_yarn/validator/imported/actions-deps-698ce9d8a0
• dependabot/npm_and_yarn/validator/imported/actions-deps-71637607c1
• dependabot/npm_and_yarn/validator/imported/actions-deps-757adad05b
• dependabot/npm_and_yarn/validator/imported/actions-deps-7f62fc18dd
• dependabot/npm_and_yarn/validator/imported/actions-deps-807db14d8a
• dependabot/npm_and_yarn/validator/imported/actions-deps-8a5060b00a
• dependabot/npm_and_yarn/validator/imported/actions-deps-8b4bdccbfb
• dependabot/npm_and_yarn/validator/imported/actions-deps-8e6b994b08
• dependabot/npm_and_yarn/validator/imported/actions-deps-95ed20c41c
• dependabot/npm_and_yarn/validator/imported/actions-deps-974e508fc2
• dependabot/npm_and_yarn/validator/imported/actions-deps-994ff37c49
• dependabot/npm_and_yarn/validator/imported/actions-deps-9a1fd07f6a
• dependabot/npm_and_yarn/validator/imported/actions-deps-a23cb908fc
• dependabot/npm_and_yarn/validator/imported/actions-deps-af3d599d94
• dependabot/npm_and_yarn/validator/imported/actions-deps-baec47a421
• dependabot/npm_and_yarn/validator/imported/actions-deps-bcbc269680
• dependabot/npm_and_yarn/validator/imported/actions-deps-bfa8aa6d75
• dependabot/npm_and_yarn/validator/imported/actions-deps-c50f8009d8
• dependabot/npm_and_yarn/validator/imported/actions-deps-c92160c12e
• dependabot/npm_and_yarn/validator/imported/actions-deps-cf72c556cb
• dependabot/npm_and_yarn/validator/imported/actions-deps-d263d934c5
• dependabot/npm_and_yarn/validator/imported/actions-deps-de759b0c8c
• dependabot/npm_and_yarn/validator/imported/actions-deps-defd35f26a
• dependabot/npm_and_yarn/validator/imported/actions-deps-e251210794
• dependabot/npm_and_yarn/validator/imported/actions-deps-e94782542e
• dependabot/npm_and_yarn/validator/imported/actions-deps-f0182aa2ae
• dependabot/npm_and_yarn/validator/imported/actions-deps-f09091c33a
• dependabot/npm_and_yarn/validator/imported/babel/plugin-transform-modules-systemjs-7.29.4
• dependabot/npm_and_yarn/validator/imported/babel/runtime-7.26.10
• dependabot/npm_and_yarn/validator/imported/brace-expansion-1.1.12
• dependabot/npm_and_yarn/validator/imported/brace-expansion-1.1.13
• dependabot/npm_and_yarn/validator/imported/brace-expansion-5.0.7
• dependabot/npm_and_yarn/validator/imported/brace-expansion-5.0.9
• dependabot/npm_and_yarn/validator/imported/js-yaml-4.1.1
• dependabot/npm_and_yarn/validator/imported/js-yaml-5.2.2
• dependabot/npm_and_yarn/validator/imported/picomatch-2.3.2
• deterministic_validation_order
• errorposf_handle_nil_pos
• extend-empty-validation
• extends-missing
• extract-walker
• feat-duplicate-check
• feat-empty-validate
• feat-path
• feat-reserved-name
• feat/249-gqlerror-is-method
• fix-73
• fix-arg-defaults
• fix-fragment-definition-directive-vars
• fix-infinit-loop
• fix/enum-value-and-directive-uniqueness
• fix/issue-337
• fix/lexer-control-char-error-hex
• fix/rules
• fix/schema-directives
• fix/schema-directives-2
• fix/syncmap/rules
• fix/unique-union-member-types
• fix_number_parsing
• fixnil
• fmterror
• fuzz-inline-fragment
• fz/formatter-nonintrospect-builtin
• fz/safer-ArgumentMap
• gh_lint
• gomod
• gqlerr-unwrap
• increment_go_1_22
• inferred-root-types
• infinite-recursion
• input-type-cycle-rejection
• input-type-validation
• integration-changes
• interface-validation
• issue-254-negative-columns
• lbarthonet/default-value-args
• lexer-off-by-1
• lexer_tweak
• lint_and_fmt
• master
• minor
• nil-non-required-vars
• no_marshal_position
• null-embedded
• panic-on-undefined-type-assertion
• parsequerywithlimit
• parser_limit_error
• pluggable-coercion
• prelude-support
• quote-description-bug
• redo_github_actions
• refactor/rules2
• refactor/rules3
• release_script
• remove-event-state
• remove-old-diff-dependency
• replacerule
• revert-168-specified-by
• scalar-leafs
• scalar_leafs_without_suggestion
• schema-default-values
• separate-validation-parsing
• shorten-test-names
• single-field-selections
• snyk-fix-4467374313a2fc745380bd5b7e7cf8ec
• snyk-fix-bdbf2518e4ab8e057c9d65d60f2e77c5
• stop-walk-on-error
• test/rules
• tweak-coverage
• union_dup_err
• unique-argument-names
• unique-directives-per-location
• unique-fragment-names
• unique-input-field-names
• unique-operation-names
• unique-variable-names
• update_go_121
• update_graphqljs_v16_12_0
• update_modules
• validate-implements
• validate-input-usage
• validation-positions
• variable-validation-cleanup
• variables-in-allowed-position
• vb-vars
• wrapnil

Build # 983

Build Type

Pull #459

circleci

Committed by jaideeppyne

Commit Message

Compare composite argument values in sameValue (#108)

sameValue compared only Kind and Raw. Object and list values keep their
contents in Children with an empty Raw, so every object value compared equal to
every other object value (and likewise for lists). OverlappingFieldsCanBeMerged
(spec section 5.3.2) therefore failed to flag same-response-name fields whose
object or list arguments differ, e.g. f(where:{code:"DE"}) and
f(where:{code:"US"}) were allowed to merge.

Compare the children too: input object fields by name (order is not
significant per the spec) and list elements by position (order is
significant). Scalars are unaffected since they carry no children.

Adds a sameValue unit test covering objects, lists, reordering and field-count
mismatches; the object/list cases fail without this change.

Signed-off-by: jaideeppyne <jaideeppyne1997@gmail.com>

Pull Request Pull Request #459: Compare composite argument values in `sameValue` (#108)

Coverage Stats

17 of 17 new or added lines in 1 file covered. (100.0%)

5192 of 5932 relevant lines covered (87.53%)

1.01 hits per line