vektah / gqlparser / 983

88%

master: 87%

Pull #459

circleci

Compare composite argument values in sameValue (#108)

sameValue compared only Kind and Raw. Object and list values keep their
contents in Children with an empty Raw, so every object value compared equal to
every other object value (and likewise for lists). OverlappingFieldsCanBeMerged
(spec section 5.3.2) therefore failed to flag same-response-name fields whose
object or list arguments differ, e.g. f(where:{code:"DE"}) and
f(where:{code:"US"}) were allowed to merge.

Compare the children too: input object fields by name (order is not
significant per the spec) and list elements by position (order is
significant). Scalars are unaffected since they carry no children.

Adds a sameValue unit test covering objects, lists, reordering and field-count
mismatches; the object/list cases fail without this change.

Signed-off-by: jaideeppyne <jaideeppyne1997@gmail.com>

17 of 17 new or added lines in 1 file covered. (100.0%)

5192 of 5932 relevant lines covered (87.53%)

1.01 hits per line