uber-go / zap

100%

master: 97%

LAST BUILD ON BRANCH pv_panic_always

branch: pv_panic_always

CHANGE BRANCH

x

Reset

• pv_panic_always
• _start_-bettertest-part_1.0
• add-singleton
• ajs-1
• ajs-add-docs
• ajs-assorted-cleanups
• ajs-bench
• ajs-better-errors
• ajs-buf
• ajs-buffer
• ajs-check
• ajs-contributing
• ajs-coveralls
• ajs-coveralls-retry
• ajs-discard-output
• ajs-docs
• ajs-encoders
• ajs-err-field
• ajs-errors
• ajs-errs
• ajs-export-encoder
• ajs-export-encoder-constructors
• ajs-export-hooks
• ajs-fx
• ajs-glide
• ajs-go
• ajs-http
• ajs-inject-encoder-into-loggers
• ajs-levels
• ajs-license
• ajs-license-check
• ajs-lion-bench
• ajs-locks
• ajs-meta-take-encoder
• ajs-msg
• ajs-nicer-nop
• ajs-panics
• ajs-pr
• ajs-project-not-milestone
• ajs-rc-2
• ajs-rc3
• ajs-readme-fix
• ajs-release
• ajs-remove-add-fields
• ajs-remove-stub-time
• ajs-sampler-flakes
• ajs-spellling
• ajs-std
• ajs-stringer
• ajs-tests
• ajs-text
• ajs-timeout
• ajs-tips
• ajs-zaptest
• akshayjshah-readme-perf
• atomic
• bettertest-part_1.0
• color
• drop_logger_level
• dynamic-level-helper
• dynamiclevel
• field_equals
• fix-license-check
• hilite
• imp_test
• json-yaml-tags
• json_add_bool
• level_enabler
• level_value
• license
• lion-bench
• log_fatal_panic
• master
• meta_apply_options
• meta_enabled
• newjson_doc_fix
• observed_filter
• pusher
• pv-open-error
• pv_base64
• pv_bench_cleanup
• pv_concurrent_write
• pv_fileexample
• pv_keyvalue_interface
• pv_keyvalue_map
• pv_remove_nest
• register-encoder
• rt_cap_level_strings
• runtime-frames
• sampler_check
• sort-benchmarks
• spy_level
• stacktrace
• stdout-stderr-no-special-casing
• syslog
• tee
• tee_logger
• text_uintptr
• travis-go-1.8
• update-benchmarks
• update-benchmarks-in-readme-with-template
• update-year
• v1.0.0
• v1.0.0-rc.2
• v1.0.0-rc.3
• v1.1.0
• v1.2.0
• v1.3.0
• v1.4.0
• v1.4.1
• v141_changelog
• wh-readme
• zapgrpc

Build # 411

Build Type

push

travis-ci

Committed by prashantv

Commit Message

Fix Check not triggering panic/exit on Panic/Fatal

Panic and Fatal should always cause a panic or exit, even if the level
is disabled. This is handled correctly in logger.Panic/Fatal/Log, but
when the CheckedMessage is used, we're not calling panic/exit.

We should always return a valid message from Check when the level is
Fatal or Panic. This means that Panic/Fatal will not be sampled, since
the sampler should not call panic/exit directly, but should defer to the
underlying logger, and there's no way to specify don't log, but call the
panic/exit functions.

Run Details

9 of 9 new or added lines in 1 file covered. (100.0%)

612 of 612 relevant lines covered (100.0%)

31397.76 hits per line