uber-go / zap

100%

master: 97%

LAST BUILD ON BRANCH ajs-errs

branch: ajs-errs

CHANGE BRANCH

x

Reset

• ajs-errs
• _start_-bettertest-part_1.0
• add-singleton
• ajs-1
• ajs-add-docs
• ajs-assorted-cleanups
• ajs-bench
• ajs-better-errors
• ajs-buf
• ajs-buffer
• ajs-check
• ajs-contributing
• ajs-coveralls
• ajs-coveralls-retry
• ajs-discard-output
• ajs-docs
• ajs-encoders
• ajs-err-field
• ajs-errors
• ajs-export-encoder
• ajs-export-encoder-constructors
• ajs-export-hooks
• ajs-fx
• ajs-glide
• ajs-go
• ajs-http
• ajs-inject-encoder-into-loggers
• ajs-levels
• ajs-license
• ajs-license-check
• ajs-lion-bench
• ajs-locks
• ajs-meta-take-encoder
• ajs-msg
• ajs-nicer-nop
• ajs-panics
• ajs-pr
• ajs-project-not-milestone
• ajs-rc-2
• ajs-rc3
• ajs-readme-fix
• ajs-release
• ajs-remove-add-fields
• ajs-remove-stub-time
• ajs-sampler-flakes
• ajs-spellling
• ajs-std
• ajs-stringer
• ajs-tests
• ajs-text
• ajs-timeout
• ajs-tips
• ajs-zaptest
• akshayjshah-readme-perf
• atomic
• bettertest-part_1.0
• color
• drop_logger_level
• dynamic-level-helper
• dynamiclevel
• field_equals
• fix-license-check
• hilite
• imp_test
• json-yaml-tags
• json_add_bool
• level_enabler
• level_value
• license
• lion-bench
• log_fatal_panic
• master
• meta_apply_options
• meta_enabled
• newjson_doc_fix
• observed_filter
• pusher
• pv-open-error
• pv_base64
• pv_bench_cleanup
• pv_concurrent_write
• pv_fileexample
• pv_keyvalue_interface
• pv_keyvalue_map
• pv_panic_always
• pv_remove_nest
• register-encoder
• rt_cap_level_strings
• runtime-frames
• sampler_check
• sort-benchmarks
• spy_level
• stacktrace
• stdout-stderr-no-special-casing
• syslog
• tee
• tee_logger
• text_uintptr
• travis-go-1.8
• update-benchmarks
• update-benchmarks-in-readme-with-template
• update-year
• v1.0.0
• v1.0.0-rc.2
• v1.0.0-rc.3
• v1.1.0
• v1.2.0
• v1.3.0
• v1.4.0
• v1.4.1
• v141_changelog
• wh-readme
• zapgrpc

Build # 298

Build Type

push

travis-ci

Committed by akshayjshah

Commit Message

Encode errors under different keys

Currently, we don't handle encoding errors in a consistent way
- `AddObject` serializes the error into the log message, but
`AddMarshaler` logs the message to standard out. Even though very few
portions of the code can fail at runtime, we end up checking and
managing errors all over the place.

This PR allows the encoder to return an error for `AddObject` and
`AddMarshaler`, which are the only two methods that can fail. However,
the field handles that error by serializing it under a different key
(errors for the key `foo` are serialized under `fooError`).

This should make our APIs less cumbersome and our error handling more
consistent. It fixes #43.

Run Details

29 of 29 new or added lines in 5 files covered. (100.0%)

505 of 505 relevant lines covered (100.0%)

37100.11 hits per line