thoughtspot / visual-embed-sdk / #3956

94%

main: 94%

Build Type

Pull #547

Committed by yinstardev

Commit Message

SCAL-313306: refactor declarative embedParams building in V1Embed

Replace imperative embedParams construction with declarative pattern to eliminate
mutation chains and improve maintainability. Each embed type now declares
contributions separately, merged once in base class.

Changes:
- Create new embedParams-builder.ts with EmbedParamsContribution interface
- Add getEmbedParamsContributions() method to TsEmbed (returns empty by default)
- Update getDefaultAppInitData() to collect and merge contributions declaratively
- Refactor AppEmbed: replaces getAppInitData() with getEmbedParamsContributions()
- Refactor LiveboardEmbed: replaces getAppInitData() with getEmbedParamsContributions()
- Refactor SearchEmbed: adds getEmbedParamsContributions(), preserves searchOptions in getAppInitData()
- Refactor SpotterEmbed: replaces getAppInitData() with getEmbedParamsContributions()
- Add contribution builders to spotter-utils and spotter-viz-utils
- Keep old builder functions for backward compatibility

Benefits:
- Eliminates spread operator chains causing hidden mutations
- Type-safe embedParams with explicit interface
- Easier to test contributions in isolation
- Cleaner code with single responsibility
- Maintains 100% backward compatibility

Tests: all 1103 tests pass

Pull Request Pull Request #547: SCAL-313306: refactor declarative embedParams building in V1Embed

Coverage Stats

2084 of 2337 branches covered (89.17%)

Branch coverage included in aggregate %.

36 of 37 new or added lines in 6 files covered. (97.3%)

54 existing lines in 3 files now uncovered.

3805 of 3913 relevant lines covered (97.24%)

140.98 hits per line