thomwiggers / onebot
72%

DEFAULT BRANCH: develop
Repo Added
Files 17
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH develop
branch: develop
CHANGE BRANCH
x

coverage: 71.595% (+1.9%) from 69.703%
34606921941

push

github

web-flow 
Fix Spotify OAuth callback crash for untracked users, add .whoami (#264)

* fix(spotify): don't crash callback when user isn't tracked

Users who only ever talk to the bot in a query were never added to
active_users, because on_privmsg bails out on any target that isn't a
channel the bot is in. get_user() then returns None, and the Spotify
OAuth callback called set_setting() on it, raising AttributeError in the
HTTP handler thread -- after it had already told the browser "Stored
your token".

- users: track users seen in a query (no channel attached), so commands
  and identification work for PM-only users.
- users: only part users from channels they were actually seen in, so a
  query-tracked user isn't dropped when the bot leaves a channel.
- users: the nickserv id function no longer looks itself up via
  get_user(), which had the same None dereference.
- spotify: bail out with a 404 when the user is unknown, wait for the
  store to complete before reporting success, only mark a code as seen
  once it worked, and log+500 on unexpected errors instead of leaking a
  traceback to the socket server.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SmGNUYmuLWVF7ptiHtdobe

* fix(users): don't track services talking to us in NOTICEs

Query tracking is for people, not for NickServ. Also exercise the real
User.set_setting path (async identification included) from the Spotify
callback test.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SmGNUYmuLWVF7ptiHtdobe

* feat(users): add a whoami command

Replies with the identity the bot resolved for you (the nickserv
account, what.cd name or hostmask, depending on identify_by) plus the
mask it has on file, so it's obvious whether the bot knows who you are
before a command silently misbehaves.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SmGNUYmuLWV... (continued)

43 of 45 new or added lines in 3 files covered. (95.56%)

1104 of 1542 relevant lines covered (71.6%)

3.58 hits per line

Relevant lines Covered
1542 RELEVANT LINES 1104 COVERED LINES
3.58 HITS PER LINE
Source Files on develop

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
34606921941 develop Fix Spotify OAuth callback crash for untracked users, add .whoami (#264) * fix(spotify): don't crash callback when user isn't tracked Users who only ever talk to the bot in a query were never added to active_users, because on_privmsg bails out o... push web-flow github
71.6
33601700712 develop chore(deps): bump the python-packages group with 4 updates (#262) Updates the requirements on [cryptography](https://github.com/pyca/cryptography), [dateparser](https://github.com/scrapinghub/dateparser), [redis](https://github.com/redis/redis-py... push web-flow github
69.7
33601664973 develop chore(deps): bump github/codeql-action in the github-actions group (#263) Bumps the github-actions group with 1 update: [github/codeql-action](https://github.com/github/codeql-action). Updates `github/codeql-action` from 4.37.3 to 4.37.9 - [Rel... push web-flow github
69.7
30697486350 develop chore(deps): bump github/codeql-action from 4 to 4.37.3 (#256) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4 to 4.37.3. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://githu... push web-flow github
69.7
30697435123 develop Fix updates push thomwiggers github
69.7
30697379858 develop chore(deps): group github-actions dependabot updates (#260) Bundle all GitHub Actions bumps into a single monthly PR, matching the existing python-packages grouping. Claude-Session: https://claude.ai/code/session_01CnCGnao1eKr5d73shj5JcR Co-au... push web-flow github
69.7
30697276146 develop chore(deps): bump actions/setup-python from 6 to 7 (#257) Bumps [actions/setup-python](https://github.com/actions/setup-python) from 6 to 7. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](https://github.com/action... push web-flow github
69.7
30697173929 develop chore(deps): update tekore requirement (#255) Updates the requirements on [tekore](https://github.com/felix-hilden/tekore) to permit the latest version. Updates `tekore` to 6.2.0 - [Release notes](https://github.com/felix-hilden/tekore/releases)... push web-flow github
69.7
30697065852 develop chore(deps): bump soupsieve from 2.8.1 to 2.8.4 (#254) Bumps [soupsieve](https://github.com/facelessuser/soupsieve) from 2.8.1 to 2.8.4. - [Release notes](https://github.com/facelessuser/soupsieve/releases) - [Commits](https://github.com/faceless... push web-flow github
69.7
30696960245 develop chore(deps): bump coverallsapp/github-action from 2.3.6 to 2.3.8 (#258) Bumps [coverallsapp/github-action](https://github.com/coverallsapp/github-action) from 2.3.6 to 2.3.8. - [Release notes](https://github.com/coverallsapp/github-action/release... push web-flow github
69.7
See All Builds (842)