thomwiggers / onebot / 34606921941

72%

push

github

Fix Spotify OAuth callback crash for untracked users, add .whoami (#264)

* fix(spotify): don't crash callback when user isn't tracked

Users who only ever talk to the bot in a query were never added to
active_users, because on_privmsg bails out on any target that isn't a
channel the bot is in. get_user() then returns None, and the Spotify
OAuth callback called set_setting() on it, raising AttributeError in the
HTTP handler thread -- after it had already told the browser "Stored
your token".

- users: track users seen in a query (no channel attached), so commands
  and identification work for PM-only users.
- users: only part users from channels they were actually seen in, so a
  query-tracked user isn't dropped when the bot leaves a channel.
- users: the nickserv id function no longer looks itself up via
  get_user(), which had the same None dereference.
- spotify: bail out with a 404 when the user is unknown, wait for the
  store to complete before reporting success, only mark a code as seen
  once it worked, and log+500 on unexpected errors instead of leaking a
  traceback to the socket server.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SmGNUYmuLWVF7ptiHtdobe

* fix(users): don't track services talking to us in NOTICEs

Query tracking is for people, not for NickServ. Also exercise the real
User.set_setting path (async identification included) from the Spotify
callback test.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SmGNUYmuLWVF7ptiHtdobe

* feat(users): add a whoami command

Replies with the identity the bot resolved for you (the nickserv
account, what.cd name or hostmask, depending on identify_by) plus the
mask it has on file, so it's obvious whether the bot knows who you are
before a command silently misbehaves.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SmGNUYmuLWV... (continued)

43 of 45 new or added lines in 3 files covered. (95.56%)

1104 of 1542 relevant lines covered (71.6%)

3.58 hits per line