tf / pageflow
99%
master: 99%

LAST BUILD BRANCH: actions
DEFAULT BRANCH: master
Repo Added
Files 486
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH perma-id-lock-2
branch: perma-id-lock-2
CHANGE BRANCH
x

2251

push

travis-ci

tf 
Prevent further cases of perma id clashes

Wrapping `RevisionComponent#save` in an advisory lock, does not
suffice for cases where the revision component is created through an
association, i.e

    revision.file_usages.create!(...)

In this case `CollectionAssociation#_create_record` [1] already starts
the transaction before the lock is required. Since the transaction is
then committed only after the advisory lock is already released, the
following race condition can occur:

    Thread 1:                       Thread 2:
    |                               |
    BEGIN                           |
    GET LOCK                        |
    SELECT MAX perma_id             |
    INSERT revision component       |
    RELEASE LOCK                    |
    |                               BEGIN
    |                               GET LOCK
    |                               SELECT MAX perma_id
    COMMIT                          |
    |                               INSERT revision component
    |                               RELEASE LOCK
    |                               COMMIT

Since the first transaction is not yet finished, the second thread
does not yet see the newly inserted perma id and calculates the same
maximum.

To ensure that the lock is acquired before the transaction starts, we
add a new class method `create_with_lock!` which then delegates to
`create!`.

For existing revision components (and models that behave like revision
components like `Page`) this race condition has never been a problem
since concurrent inserts are not that likely within a revision (and we
do not care about non-unique perma ids accross entries). We only
noticed the problem for file usages now since those are created by a
batch of requests when multiple files are uploaded at the same time.
So for now we use the new `create_with_lock!` method only in
`DraftEntry.create_file!`.

[1] https://github.com/rails/rails/blob/b9ca94cae/activerecord/lib... (continued)

17109 of 17233 relevant lines covered (99.28%)

58.9 hits per line

Relevant lines Covered
17233 RELEVANT LINES 17109 COVERED LINES
58.9 HITS PER LINE
Source Files on perma-id-lock-2
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
2251 perma-id-lock-2 Prevent further cases of perma id clashes Wrapping `RevisionComponent#save` in an advisory lock, does not suffice for cases where the revision component is created through an association, i.e revision.file_usages.create!(...) In this case `... push tf travis-ci pending completion  
See All Builds (1073)