tf / pageflow
99%
master: 99%

LAST BUILD BRANCH: actions
DEFAULT BRANCH: master
Repo Added
Files 486
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH atmo-fixes
branch: atmo-fixes
CHANGE BRANCH
x

2798

push

travis-ci

tf 
Prevent resuming atmo of other section

Before, changing to a section without atmo only paused the atmo multi
player without changing its current file id. When a media content
element in a section without atmo was then set to turn down atmo
during playback, pausing the media element resumed the atmo that had
been playing for a previous section.

To work around this issue, we always fade the multiplayer on section
change - even to an undefined audio file perma id if non is given. We
change the `PlayerSourceIDMap` to return a `Null` player if no sources
can be found for the passed id. When moving back and forth between a
section with atmo and an adjacent section without atmo, this will now
cause players for the same audio file to be requested whenever we
enter the section with atmo. To prevent creating multiple players in
this case, we change the map to return the current player if it
matches the passed audio file id.

Now that undefined sources are a handled case, we can also fix another
issue. So far, sources were only ever added to the
`PlayerSourceIDMap`. When deleting an audio file that was previously
used as atmo, the sources would remain in the map, causing the atmo to
contnue playing every time the section is encountered, even though the
file is no longer visible in the atmo input view.  After reloading the
entry, players for undefined sources were requested.

We therefore update `SectionAtmo` to update the sources mapping also
when no sources are found. That way atmo continues playing, when the
file is deleted. But once the section is left and entered again the
mapping will be updated and no atmo will be played.

REDMINE-18017

18200 of 18348 relevant lines covered (99.19%)

48.0 hits per line

Relevant lines Covered
18348 RELEVANT LINES 18200 COVERED LINES
48.0 HITS PER LINE
Source Files on atmo-fixes

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
2798 atmo-fixes Prevent resuming atmo of other section Before, changing to a section without atmo only paused the atmo multi player without changing its current file id. When a media content element in a section without atmo was then set to turn down atmo during... push tf travis-ci pending completion  
See All Builds (1073)