teor2345 / tor

63%

master: 64%

LAST BUILD ON BRANCH bug31482

branch: bug31482

CHANGE BRANCH

x

Reset

• bug31482
• 24805-phoul
• b23588a-squashed
• b23588a-squashed-master
• backports_029_20190809_029
• backports_029_20190809_035
• backports_029_20190809_040
• backports_029_20190809_041
• backports_029_20190809_master
• backports_035_040_20190812_035
• backports_035_040_20190812_040
• backports_035_040_20190812_041
• backports_035_040_20190812_master
• bug23512-v2-029-fixes
• bug23512-v4-029-fixes-keep-typedef
• bug23512-v4-034-fixes-keep-typedef
• bug23818
• bug23818_029
• bug23818_035
• bug23818_master
• bug24661-035
• bug25733_029
• bug27073_034
• bug28096-029
• bug28096-029-squashed
• bug28096-034-squashed
• bug28096-035
• bug28096-035-squashed
• bug28096-ticket28308-035
• bug28096-ticket28308-make-test
• bug28096-ticket28308-master
• bug28096-ticket28308-show-test-log
• bug28399
• bug28399-034
• bug28440-035
• bug28441-035
• bug28525_029
• bug28525_035
• bug28554
• bug28554-033
• bug28568-029
• bug28591-035
• bug28636_squashed
• bug28656_035
• bug28689
• bug28821
• bug28826-035
• bug28925_040_squashed
• bug28925_master_squashed
• bug29015
• bug29017-033
• bug29017-master-rebase
• bug29018
• bug29029-029
• bug29036-029
• bug29036-29962-034
• bug29036-29962-035
• bug29036-29962-040
• bug29036-29962-master
• bug29144_035
• bug29500
• bug29500_040
• bug29500_040_monoinit
• bug29500_master_monoinit
• bug29527_040
• bug29527_040_merge_master
• bug29528_029
• bug29528_034
• bug29528_035
• bug29528_040
• bug29528_040_just_maketest
• bug29528_040_maketest
• bug29528_040_testlog
• bug29528_master
• bug29599_029
• bug29599_033
• bug29599_master
• bug29601_035
• bug29612_035
• bug29640
• bug29640_040
• bug29643_040
• bug29645_diagnostic_034
• bug29645_diagnostic_035
• bug29645_diagnostic_040
• bug29645_diagnostic_master
• bug29703_029
• bug29703_034
• bug29703_chutney_ci_029
• bug29706_029_minimal
• bug29706_029_refactor
• bug29706_034_minimal_merge
• bug29706_034_refactor
• bug29706_035_refactor
• bug29706_040_minimal_merge
• bug29706_040_refactor
• bug29706_master_refactor
• bug29824_034
• bug29896_034_no_refactor
• bug29896_034_no_refactor_master_merge
• bug29896_035_no_refactor
• bug29896_035_no_refactor_master_merge
• bug29897_040
• bug29913
• bug29958
• bug29959-040
• bug29959-master
• bug29960
• bug29960_cant_fail
• bug30001_master
• bug30011_035
• bug30011_040
• bug30011_master
• bug30041_029
• bug30109
• bug30109_040
• bug30112
• bug30184_029
• bug30184_034
• bug30263_040
• bug30263_master
• bug30455_041
• bug30455_master
• bug30713_035
• bug30713_040
• bug30713_master
• bug30721
• bug30721_wip
• bug30744_035
• bug30744_040
• bug30744_master
• bug30780
• bug30781_029
• bug30781_034
• bug30781_035
• bug30781_040
• bug30781_master
• bug30799
• bug30821
• bug30840
• bug30956_041
• bug30956_master
• bug30958_029
• bug30958_035
• bug30958_040
• bug30958_041
• bug30958_30956_master
• bug30958_30956_master_merge_30956
• bug30958_master
• bug31334
• bug31335_042
• bug31335_master
• bug31343_31374_029
• bug31343_31374_035
• bug31343_31374_040
• bug31343_31374_041
• bug31343_31374_master
• bug31408_035
• bug31408_040
• bug31408_041
• bug31408_master
• bug31418
• bug31461_release_041
• bug31462_30979_master
• bug31463_035
• bug31463_040
• bug31463_041
• bug31463_master
• bug31482_035
• bug31531
• bug31571
• bug31571_035
• bug31571_040
• bug31571_041
• bug31571_master
• bug31594
• bug31594_040
• bug31594_041
• bug31594_master
• bug31612
• bug31614_035
• bug31614_040
• bug31614_041
• bug31614_master
• bug31615_040
• bug31615_041
• bug31615_master
• bug31657_035
• bug31657_040
• bug31657_041
• bug31657_master
• bug31677
• bug31679
• bug31734
• bug31734_31614_035
• bug31736_035
• bug31736_040
• bug31736_041
• bug31736_master
• bug31793
• bug31825
• bug31837_035
• bug31837_040
• bug31837_041
• bug31837_master
• bug31838
• bug31854_042
• bug31854_042_rebased
• bug31859_029
• bug31859_035
• bug31859_040
• bug31859_041
• bug31859_master
• bug31884_035
• bug31884_040
• bug31884_041
• bug31884_master
• bug31897_041
• bug31897_master
• bug31922_042
• bug31939_035
• bug31939_040
• bug31939_041
• bug31939_master
• bug32060_042
• bug32124_042
• bug32124_master
• bug32213
• bug32213_bad_32339_32344
• bug32240_029
• bug32240_035
• bug32240_040
• bug32240_041
• bug32240_042
• bug32240_32242_029
• bug32240_32242_035
• bug32240_32242_040
• bug32240_32242_041
• bug32240_32242_042
• bug32240_32242_master
• bug32240_dir
• bug32240_master
• bug32240_sandbox
• bug32295_042_only
• bug32295_master_revert
• bug32295_master_tests
• bug32401
• bug32402_042
• bug32402_master
• bug32449
• bug32449_035
• bug32449_040
• bug32449_041
• bug32449_042
• bug32449_master
• bug32588
• bug32588_035
• bug32588_035_squashed
• bug32588_035_tests
• bug32588_040
• bug32588_041
• bug32588_042
• bug32588_043
• bug32588_master
• bug32588_master_tests
• bug32663
• bug32663-squashed
• bug32663-test
• bug33087_041
• bug33087_042
• bug33087_043
• bug33087_master
• bug33195_035
• bug33195_041
• bug33195_042
• bug33195_043
• bug33195_master
• bug33284
• bug33285
• bug33374_043
• bug33491_master
• bug33641
• bug33643_035
• bug33643_master
• bug33646_043
• bug33673_035
• bug33673_041
• bug33673_042
• bug33673_043
• bug33673_master
• bug33674_043
• bug33674_master
• bug33899
• bug33917
• bug33918
• bug4631
• chutney_ci_v4_029
• chutney_ci_v4_035
• chutney_ci_v4_040
• chutney_ci_v4_041
• chutney_ci_v4_master
• comment-fixes-2018-11
• doc31089_029
• doc31089_035
• doc31089_040
• doc31089_041
• doc31089_master
• git-script-fix
• macos_image_10_1
• macos_image_10_3
• macos_image_11_2
• maint-0.2.9
• maint-0.2.9-rollup-20190314
• maint-0.3.4-rollup-20190314
• maint-0.3.5
• maint-0.3.5-rollup-20190314
• maint-0.4.0
• maint-0.4.1
• maint-0.4.2
• maint-0.4.3
• master
• master-coverage-test
• master-coverage-test-new
• master-rollup-20190314
• pr1529_changes_fix
• pr1707_squashed
• protocommas_029_squashed
• protocommas_034
• protozero1
• release-0.2.9
• release-0.3.5
• release-0.4.0
• release-0.4.1
• release-0.4.2
• rust-panic1-034
• rust-panic1-035
• rust-panic1-040
• rust-panic1-master
• rustfmt-notravis
• test31408
• test_headers
• ticket16564
• ticket20218_merged
• ticket21003
• ticket21377_035_01_autosquashed_rebased
• ticket21377_master_01_autosquashed_rebased
• ticket24803-029
• ticket24803-029-les
• ticket24803-029-shaw
• ticket24838
• ticket24838-24805
• ticket27251
• ticket27468-034
• ticket27821
• ticket28113-029
• ticket28113-master
• ticket28113-squashed
• ticket28308-035-squashed
• ticket28308-master-squashed
• ticket28318-035
• ticket28453
• ticket28459-034
• ticket28795_029
• ticket28795_035
• ticket28795_040
• ticket28795_041
• ticket29004-wip
• ticket29019
• ticket29221_squashed
• ticket29241_035
• ticket29241_master
• ticket29530_035
• ticket29603
• ticket29702_035
• ticket29806_034_squashed
• ticket29806_035_squashed_merged
• ticket29806_040_squashed_merged
• ticket29806_master_squashed_merged
• ticket29879
• ticket29897_035
• ticket29897_master
• ticket30114
• ticket30117
• ticket30117_035
• ticket30234_035
• ticket30234_035_wip_test
• ticket30261
• ticket30591_035
• ticket30591_040
• ticket30591_041
• ticket30591_master
• ticket30591_master_xfail
• ticket30591_wip_test
• ticket30901
• ticket30901_redux
• ticket30955
• ticket30967
• ticket31314
• ticket31314_29879
• ticket31545
• ticket31549_035
• ticket31554_035
• ticket31554_040
• ticket31554_041
• ticket31554_master
• ticket31684
• ticket31684_squashed
• ticket31839
• ticket31840
• ticket31919
• ticket31919_bionic
• ticket31919_bionic_035
• ticket31919_bionic_040
• ticket31919_bionic_chutney_trusty
• ticket31919_bionic_master
• ticket31919_bionic_zstd
• ticket31919_master
• ticket31919_xenial
• ticket32086
• ticket32086_035
• ticket32086_040
• ticket32086_041
• ticket32086_042
• ticket32086_master
• ticket32123
• ticket32123_rebased
• ticket32123_rebased_squashed
• ticket32163
• ticket32177_029
• ticket32177_035
• ticket32177_040
• ticket32177_041
• ticket32177_042
• ticket32177_master
• ticket32191_042
• ticket32191_master
• ticket32216
• ticket32232
• ticket32241_029
• ticket32241_035
• ticket32241_040
• ticket32241_041
• ticket32241_042
• ticket32241_master
• ticket32244
• ticket32245
• ticket32347
• ticket32397
• ticket32410
• ticket32450
• ticket32451
• ticket32500
• ticket32500_029
• ticket32500_035
• ticket32500_040
• ticket32500_041
• ticket32500_042
• ticket32500_master
• ticket32522
• ticket32559
• ticket32604
• ticket32609
• ticket32610
• ticket32629_029
• ticket32629_035
• ticket32629_040
• ticket32629_041
• ticket32629_042
• ticket32629_master
• ticket32637
• ticket32705-diagnostic
• ticket32732
• ticket32792
• ticket32792_035
• ticket32792_041
• ticket32792_042
• ticket32792_043
• ticket32792_master
• ticket32818
• ticket32822
• ticket32845
• ticket32962
• ticket32962_rebased
• ticket32994
• ticket32994-squashed
• ticket33075_035
• ticket33075_040
• ticket33075_041
• ticket33075_042
• ticket33075_master
• ticket33091
• ticket33195_035
• ticket33222
• ticket33280_master
• ticket33334
• ticket33373
• ticket33608
• ticket33608_043
• ticket33618
• ticket33633
• ticket33678_043
• ticket33678_master
• ticket33679
• ticket33817
• ticket33901
• ticket34200
• travis-osx-v8

Build # 786

Build Type

push

travis-ci

Committed by teor2345

Commit Message

monotime: avoid overflow when converting between coarse and ms on Apple

This fix makes sure that the token bucket rate_per_sec_to_rate_per_step()
can not overflow with large rates on iOS, and any other platform where:
  monotime.numerator^2 / monotime.denominator > 512

It also avoids overflow for any other callers that convert values of:
  msec > 2^64 / (10^6 * monotime.denominator)
  coarse_stamp > 2^64 / (monotime.numerator^2 / monotime.denominator)

(These bounds are approximate: the code does exact calculations.)

Fixes bug 31482; bugfix on 0.3.4.1-alpha.

Run Details

47273 of 75221 relevant lines covered (62.85%)

48244.1 hits per line