tarantool / luajit
89%
tarantool/master: 93%

LAST BUILD BRANCH: ligurio/gh-1279-recording-getmetatable
DEFAULT BRANCH: tarantool/master
Repo Added
Files 89
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH ligurio/lj-881-fix-concat
branch: ligurio/lj-881-fix-concat
CHANGE BRANCH
x

coverage: 88.59% (+0.4%) from 88.157%
6928298506

push

github

ligurio 
LJ_GC64: Fix lua_concat().

Reported by Mathias Westerdahl.

(cherry picked from commit 633f265f6)

Lua 5.1 Reference Manual [1] defines a function `lua_concat`, that:

> void lua_concat (lua_State *L, int n);
>
> Concatenates the n values at the top of the stack, pops them, and leaves
> the result at the top.

Without the patch, `lua_concat()` behaved incorrectly with userdata with
the defined `__concat` metamethod. The problem is GC64-specific.

Assuming we have three literals and a userdata with the defined
`__concat` metamethod on top of the Lua stack:

1 [string]
2 [string]
3 [string]
4 [string]
5 [userdata] <--- top

On attempt to concatenate *two* items on top of the Lua stack,
`lua_concat()` concatenates *four* items and leaves the result on top of
the Lua stack:

1 [string]
2 [string][string][string][userdata] <--- top

The problem is in the incorrect calculation of `n` counter in the loop
in the implementation of function `lua_concat`. Without the fix, `n` is
equal to 3 at the end of the first iteration, and therefore it goes to
the next iteration of concatenation. In the fixed implementation of
`lua_concat()`, `n` is equal to 1 at the end of the first loop iteration,
decremented in a loop postcondition, and breaks the loop.

For details see implementation of `lj_meta_cat()` in <src/lj_meta.c>.

The patch fixes incorrect behaviour.

1. https://www.lua.org/manual/5.1/manual.html

Sergey Bronnikov:
* added the description and the test for the problem

Part of tarantool/tarantool#9145

5372 of 5980 branches covered (0.0%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

225 existing lines in 12 files now uncovered.

20608 of 23346 relevant lines covered (88.27%)

2760500.93 hits per line

Relevant lines Covered
23346 RELEVANT LINES 20608 COVERED LINES
2760500.93 HITS PER LINE
Source Files on ligurio/lj-881-fix-concat

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
6928298506 ligurio/lj-881-fix-concat LJ_GC64: Fix lua_concat(). Reported by Mathias Westerdahl. (cherry picked from commit 633f265f6) Lua 5.1 Reference Manual [1] defines a function `lua_concat`, that: > void lua_concat (lua_State *L, int n); > > Co... push ligurio github
88.59
6915107192 ligurio/lj-881-fix-concat LJ_GC64: Fix lua_concat(). Reported by Mathias Westerdahl. (cherry picked from commit 633f265f6) Lua 5.1 Reference Manual [1] defines a function `lua_concat`, that: > void lua_concat (lua_State *L, int n); > > Co... push ligurio github
88.16
6877584730 ligurio/lj-881-fix-concat LJ_GC64: Fix lua_concat(). Reported by Mathias Westerdahl. (cherry picked from commit 633f265f6) Lua 5.1 Reference Manual [1] defines a function `lua_concat`, that: > void lua_concat (lua_State *L, int n); > > Co... push ligurio github
88.29
6875046515 ligurio/lj-881-fix-concat LJ_GC64: Fix lua_concat(). Reported by Mathias Westerdahl. (cherry picked from commit 633f265f6) Lua 5.1 Reference Manual [1] defines a function `lua_concat`, that: > void lua_concat (lua_State *L, int n); > > Co... push ligurio github
88.16
6874935084 ligurio/lj-881-fix-concat test.h [TO SQUASH] push ligurio github
88.12
6824342751 ligurio/lj-881-fix-concat LJ_GC64: Fix lua_concat(). Reported by Mathias Westerdahl. (cherry picked from commit 633f265f6) Lua 5.1 Reference Manual [1] defines a function `lua_concat`, that: > void lua_concat (lua_State *L, int n); > > Co... push ligurio github
88.17
6469161353 ligurio/lj-881-fix-concat LJ_GC64: Fix lua_concat(). Reported by Mathias Westerdahl. (cherry picked from commit 633f265f6) Lua 5.1 Reference Manual [1] defines a function `lua_concat`, that: > void lua_concat (lua_State *L, int n); > > Co... push ligurio github
88.2
6432825820 ligurio/lj-881-fix-concat LJ_GC64: Fix lua_concat(). Reported by Mathias Westerdahl. (cherry picked from commit 633f265f6) Lua 5.1 Reference Manual [1] defines a function `lua_concat`, that: > void lua_concat (lua_State *L, int n); > > Co... push ligurio github
88.1
6432519503 ligurio/lj-881-fix-concat LJ_GC64: Fix lua_concat(). Reported by Mathias Westerdahl. (cherry picked from commit 633f265f6) Lua 5.1 Reference Manual [1] defines a function `lua_concat`, that: > void lua_concat (lua_State *L, int n); > > Co... push ligurio github
88.05
6394721161 ligurio/lj-881-fix-concat LJ_GC64: Fix lua_concat(). Reported by Mathias Westerdahl. (cherry picked from commit 633f265f6) Lua 5.1 Reference Manual [1] defines a function `lua_concat`, that: > void lua_concat (lua_State *L, int n); > > Co... push ligurio github
88.23
See All Builds (1340)