tarantool / luajit
89%
tarantool/master: 93%

LAST BUILD BRANCH: skaplun/luajit-performance-tests
DEFAULT BRANCH: tarantool/master
Repo Added
Files 89
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH fckxorg/gh-8140-crash-in-allocator
branch: fckxorg/gh-8140-crash-in-allocator
CHANGE BRANCH
x

coverage: 88.882% (+0.05%) from 88.835%
7744948910

push

github

igormunkin 
sysprof: disable runtime host symtab updates

The symtab update for newly loaded shared libraries requires
memory allocation, which is not signal-safe and can cause
crashes. Updating symtab in a VM hook is not a viable option
either, as there are no guarantees that the symbol will be
dumped before its address is streamed. This patch completely
disables the runtime updates of the symtab for host symbols.
That means all Lua-C modules, FFI modules, and shared libraries
must be loaded before starting the profiler.

There is no test along with the patch for two main reasons:
1. The signal should land on an instruction inside the allocator
such that the second allocator call would cause a crash because of
an inconsistent inner state. Although we have ptrace-based
machinery for testing, the control is not that fine-grained. The
only option we have left is to rely on empirical offsets, which
is not a robust solution. Moreover, it is possible to build LuaJIT
with `malloc` as an allocator, and the test should be adapted to
that too. Needless to say, malloc sources may differ from
platform to platform, making the test unreliable.

2. Regression is unlikely here since this patch removes the only
call that could allocate memory inside the signal handler.

Resolves tarantool/tarantool#8140

5403 of 5998 branches covered (0.0%)

Branch coverage included in aggregate %.

20700 of 23370 relevant lines covered (88.58%)

2742623.68 hits per line

Relevant lines Covered
23370 RELEVANT LINES 20700 COVERED LINES
2742623.68 HITS PER LINE
Source Files on fckxorg/gh-8140-crash-in-allocator

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
7744948910 fckxorg/gh-8140-crash-in-allocator sysprof: disable runtime host symtab updates The symtab update for newly loaded shared libraries requires memory allocation, which is not signal-safe and can cause crashes. Updating symtab in a VM hook is not a viable option either, as there are ... push igormunkin github
88.88
7462347955 fckxorg/gh-8140-crash-in-allocator sysprof: disable runtime host symtab updates The symtab update for newly loaded shared libraries requires memory allocation, which is not signal-safe and can cause crashes. Updating symtab in a VM hook is not a viable option either, as there are ... push fckxorg github
88.84
7129212578 fckxorg/gh-8140-crash-in-allocator sysprof: disable runtime host symtab updates The symtab update for newly loaded shared libraries requires memory allocation, which is not signal-safe and can cause crashes. Updating symtab in a VM hook is not a viable option either, as there are ... push fckxorg github
88.61
See All Builds (1888)