tarantool / luajit
93%
tarantool/master: 93%

LAST BUILD BRANCH: ligurio/gh-xxxx-fix-sysprof-opts-processing
DEFAULT BRANCH: tarantool/master
Repo Added
Files 89
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH fckxorg/fix-argv-handling
branch: fckxorg/fix-argv-handling
CHANGE BRANCH
x

coverage: 92.973% (+0.02%) from 92.952%
13007433264

push

github

Buristan 
Fix command-line argv handling.

(cherry-picked from commit 9ebebc9b5)

Before the patch, there was a situation where `luaL_newstate()` could
fail in `main()` and the `argv[0]` could be used as a progname in
`l_message()`. However, `argv[0]` is not guaranteed to be non-NULL, so
the segmentation fault could occur. This patch fixes the issue by using
the predefined name in that case. Moreover, it refactors the
`l_message()`, so now there is no need to pass the program name
everywhere.

The patch is tested with the help of the mocking of `luaL_newstate` by
providing an error-injected implementation of it and preloading it. For
preload to work, the LuaJIT must be built with dynamic build mode
enabled. The corresponding flavor is added to the CI only for x86_64
Debug build to avoid CI jobs outgrowing.

The <gh-8594-sysprof-ffunc-crash.test.c> inspects internal symbols from
the LuaJIT static library, so it can't be linked for shared build. The
test is disabled for the dynamic build mode.

Since the Linux kernel 5.18-rc1 release, `argv` is forced to a single
empty string if it is empty [1], so the issue is not reproducible on new
kernels. You may inspect the `dmesg` log for the corresponding warning
entrance.

Maxim Kokryashkin:
* added the description and the test for the problem

[1]: https://lore.kernel.org/all/20220201000947.2453721-1-keescook@chromium.org/

Part of tarantool/tarantool#10709

5694 of 6033 branches covered (94.38%)

Branch coverage included in aggregate %.

7 of 10 new or added lines in 1 file covered. (70.0%)

8 existing lines in 3 files now uncovered.

21706 of 23438 relevant lines covered (92.61%)

2963806.57 hits per line

Relevant lines Covered
23438 RELEVANT LINES 21706 COVERED LINES
2963806.57 HITS PER LINE
Source Files on fckxorg/fix-argv-handling

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
13007433264 fckxorg/fix-argv-handling Fix command-line argv handling. (cherry-picked from commit 9ebebc9b5) Before the patch, there was a situation where `luaL_newstate()` could fail in `main()` and the `argv[0]` could be used as a progname in `l_messa... push Buristan github
92.97
12984745846 fckxorg/fix-argv-handling Fix command-line argv handling. (cherry-picked from commit 9ebebc9b5) Before the patch, there was a situation where `luaL_newstate()` could fail in `main()` and the `argv[0]` could be used as a progname in `l_messa... push Buristan github
93.03
12946978891 fckxorg/fix-argv-handling Fix command-line argv handling. (cherry-picked from commit 9ebebc9b5) Before the patch, there was a situation where `luaL_newstate` could fail in main and the `argv[0]` could be used as a progname in `l_message`. H... push Buristan github
92.98
12927497103 fckxorg/fix-argv-handling Fix command-line argv handling. (cherry-picked from commit 9ebebc9b5) Before the patch, there was a situation where `luaL_newstate` could fail in main and the `argv[0]` could be used as a progname in `l_message`. H... push Buristan github
92.98
12924826641 fckxorg/fix-argv-handling Fix command-line argv handling. (cherry-picked from commit 9ebebc9b5) Before the patch, there was a situation where `luaL_newstate` could fail in main and the `argv[0]` could be used as a progname in `l_message`. H... push Buristan github
92.98
8648539856 fckxorg/fix-argv-handling Fix command-line argv handling. (cherry-picked from commit 9ebebc9b5) Before the patch, there was a situation where `luaL_newstate` could fail in main and the `argv[0]` could be used as a progname in `l_message`. H... push mkokryashkin github
92.61
8646804024 fckxorg/fix-argv-handling Fix command-line argv handling. (cherry-picked from commit 9ebebc9b5) Before the patch, there was a situation where `luaL_newstate` could fail in main and the `argv[0]` could be used as a progname in `l_message`. H... push mkokryashkin github
92.57
8639131575 fckxorg/fix-argv-handling Fix command-line argv handling. (cherry-picked from commit 9ebebc9b5) Before the patch, there was a situation where `luaL_newstate` could fail in main and the `argv[0]` could be used as a progname in `l_message`. H... push mkokryashkin github
92.61
8639043424 fckxorg/fix-argv-handling Fix command-line argv handling. (cherry-picked from commit 9ebebc9b5) Before the patch, there was a situation where `luaL_newstate` could fail in main and the `argv[0]` could be used as a progname in `l_message`. H... push mkokryashkin github
92.53
8638530688 fckxorg/fix-argv-handling Fix command-line argv handling. (cherry-picked from commit 9ebebc9b5) Before the patch, there was a situation where `luaL_newstate` could fail in main and the `argv[0]` could be used as a progname in `l_message`. H... push mkokryashkin github
92.6
See All Builds (1555)