tarantool / luajit / 12946978891

93%

tarantool/master: 93%

push

github

Fix command-line argv handling.

(cherry-picked from commit 9ebebc9b5)

Before the patch, there was a situation where `luaL_newstate` could fail
in main and the `argv[0]` could be used as a progname in `l_message`.
However, `argv[0]` is not guaranteed to be non-NULL, so the segmentation
fault could occur. This patch fixes the issue by using the predefined
name in that case. Moreover, it refactors the `l_message`, so now there
is no need to pass `pname` everywhere.

The patch is tested with the help of the mocking of `luaL_newstate` by
providing an error-injected implementation of it and preloading it. For
preload to work, the LuaJIT must be built with dynamic build mode
enabled. The corresponding flavor is added to the CI only for x86_64
Debug build to avoid CI jobs outgrowing.

The <gh-8594-sysprof-ffunc-crash.test.c> inspects internal symbols from
the LuaJIT static library, so it can't be linked for shared build. The
test is disabled for the dynamic build mode.

Since the Linux kernel 5.18-rc1 release, `argv` is forced to a single
empty string if it is empty [1], so the issue is not reproducible on new
kernels. You may inspect the `dmesg` log for the corresponding warning
entrance.

Maxim Kokryashkin:
* added the description and the test for the problem

[1]: https://lore.kernel.org/all/20220201000947.2453721-1-keescook@chromium.org/

Part of tarantool/tarantool#10709

5695 of 6031 branches covered (94.43%)

Branch coverage included in aggregate %.

7 of 10 new or added lines in 1 file covered. (70.0%)

21702 of 23433 relevant lines covered (92.61%)

2948711.56 hits per line