tarantool / go-storage

94%

master: 90%

LAST BUILD ON BRANCH bigbes/gh-61-implement-count

branch: bigbes/gh-61-implement-count

CHANGE BRANCH

x

Reset

• bigbes/gh-61-implement-count
• bigbes/gh-29-dummy-driver
• bigbes/gh-29-etcd-driver
• bigbes/gh-29-locker-helpers
• bigbes/gh-29-locker-package
• bigbes/gh-29-locker/dummy-driver
• bigbes/gh-29-locker/etcd-driver
• bigbes/gh-29-locker/locker-package
• bigbes/gh-29-locker/storage-wiring
• bigbes/gh-29-locker/tcs-driver
• bigbes/gh-29-storage-wiring
• bigbes/gh-29-tcs-driver
• bigbes/gh-30-basic-integration-tests
• bigbes/gh-31-readme-md
• bigbes/gh-34-remove-mocks
• bigbes/gh-no-add-additional-marshallers
• bigbes/gh-no-add-go-generate-target
• bigbes/gh-no-add-legacy-namer
• bigbes/gh-no-connect-unify-probin
• bigbes/gh-no-etcdtest
• bigbes/gh-no-fix-govulncheck
• bigbes/gh-no-fix-interface
• bigbes/gh-no-fix-namer-prefixes
• bigbes/gh-no-fix-nil-hasher
• bigbes/gh-no-fix-watch-bug
• bigbes/gh-no-full-key-method
• bigbes/gh-no-hex-codecs
• bigbes/gh-no-hex-codecs-v2
• bigbes/gh-no-namer-key-prefix
• bigbes/gh-no-prefix-check
• bigbes/gh-no-prefixed-leading-slash
• bigbes/gh-no-refactor-parts
• bigbes/gh-no-remove-typed-storage
• bigbes/gh-no-tarantool-v3
• bigbes/gh-no-tx-storage-wrapper
• bigbes/gh-no-unnamed-codec
• bigbes/gh-no-update-actions
• bigbes/gh-no-update-contributing-md
• bigbes/gh-no-update-golangci-lint
• bigbes/gh-no-v2
• bigbes/release-v1.1.0
• bigbes/release-v1.1.1
• bigbes/release-v1.1.2
• bigbes/release-v1.2.0
• bigbes/release-v1.3.0
• bigbes/release-v1.4.0
• bigbes/release-v1.5.0
• bigbes/release-v1.6.0
• bigbes/release-v1.6.1
• bigbes/tntp-7585-new-namer
• bigbes/tntp-7587-codec-api
• bigbes/tntp-7587-examples
• bigbes/tntp-7587-new-namer
• bigbes/tntp-7587-prefixed-storage-wrapper
• bigbes/tntp-7587-store-api
• bigbes/tntp-7587-tx-api
• bigbes/tntp-7706-integrity-empty-watch
• bigbes/tntp-7707-integrity-empty-range
• bigbes/tntp-7708-watch-signal-contract
• bigbes/tntp-7709-namer-multi-segment
• bigbes/tntp-7710-integrity-singleton
• bigbes/tntp-7780-fix-admin-for-connect-v2
• ci/inline-govulncheck
• g.rybakov/123
• g.rybakov/gh-25-integrity-predicates
• g.rybakov/gh-26-fix-non-empty-range
• g.rybakov/tntp-4544-add-dummy-driver
• g.rybakov/tntp-7387-add-ping-tcs
• g.rybakov/tntp-7387-fix-probe-returns
• g.rybakov/tntp-7387-remove-ssl-build-tag
• g.rybakov/tntp-7780-connect-timeout
• g.rybakov/tntp-7780-fix-admin-for-connect
• gh-no-range-double-slash
• master
• mockird31/TNTP-4192-usage-examples
• mockird31/fix-prefix-generate
• mockird31/gh-23-extend-validated-result
• mockird31/gh-24-prefix-deleteion
• mockird31/gh-24-prefix-deletion
• mockird31/gh-30-integration-tests-integrity.Typed
• oleg-jukovec/connect-schema-fixes
• oleg-jukovec/replace-etcd-client-with-interface
• oleg-jukovec/storage-create-helper
• origin/mockird31/gh-30-integration-tests-integrity.Typed
• refs/tags/v1.1.0
• refs/tags/v1.1.1
• refs/tags/v1.1.2
• refs/tags/v1.2.0
• refs/tags/v1.3.0
• refs/tags/v1.4.0
• refs/tags/v1.5.0
• refs/tags/v1.6.0
• refs/tags/v1.6.1
• v2

Build # 25038391294

Build Type

Pull #64

github

Committed by bigbes

Commit Message

fix: rewrite VersionEqual/NotEqual against 0 to count predicate

TCS errors when a mod_revision predicate references a key that does not
exist, so etcd's canonical absence/presence idioms VersionEqual(key, 0)
and VersionNotEqual(key, 0) failed against TCS. The encoder now detects
this shape and emits the TCS-native count target on the wire (== 0 / != 0),
mirroring the rewrite TCS's server-side etcd shim performs for MOD == 0
and MOD != 0. The Predicate value is unchanged; only wire bytes differ.
Other version comparisons and non-zero values are not rewritten.

Closes #61

Pull Request Pull Request #64: fix: rewrite VersionEqual/NotEqual against 0 to count predicate

Coverage Stats

14 of 14 new or added lines in 1 file covered. (100.0%)

1860 of 1979 relevant lines covered (93.99%)

27.55 hits per line