tarantool / go-storage
90%

DEFAULT BRANCH: master
Repo Added
Files 49
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH master
branch: master
CHANGE BRANCH
x

coverage: 89.915% (+0.009%) from 89.906%
26637173979

push

github

bigbes 
hasher: accept nil and empty input as the empty-string digest

Storage backends round-trip empty stored values as nil, so a read of a
legitimately-empty value reached the validator with body=nil and exploded
at the SHA-256 hash check ("data is nil") and the RSA-PSS verifier check
("failed to get hash: data is nil"). The only workaround was
IgnoreVerificationError(), which defeats the integrity layer.

Drop the data == nil guard from sha1/sha256 — hash.Hash.Write(nil) is
well-defined, both nil and []byte{} now produce the empty-input digest.
ErrDataIsNil was internal-only; remove it.

Pin the contract at every layer: nil/empty parity in the hasher units,
sign+verify acceptance plus empty-signature rejection in rsapss, direct
empty-body validator coverage (value-only, value+hash, value+hash+sig),
and a TxPut([]byte{})/TxGet round-trip mirroring the reproducer against
every backend.

Also unflake driver/etcd locker tests: each test was creating its 30s
deadline ctx before calling createTestDriverConcrete, which spins up a
fresh embedded etcd cluster and can take >20s on slow CI runners. The
bootstrap consumed most of the budget, leaving Unlock's session.Close →
Revoke to fail at the last hop with "context deadline exceeded" — the
session is bound to the caller's ctx via concurrency.WithContext. Move
the ctx below cluster bootstrap in every locker test so the 30s bounds
only the actual locker operations. Observed on PR #107 run-tests (1.23);
1.24 and stable were green.

3807 of 4234 relevant lines covered (89.91%)

512.68 hits per line

Relevant lines Covered
4234 RELEVANT LINES 3807 COVERED LINES
512.68 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
26637173979 master hasher: accept nil and empty input as the empty-string digest Storage backends round-trip empty stored values as nil, so a read of a legitimately-empty value reached the validator with body=nil and exploded at the SHA-256 hash check ("data is nil... push bigbes github
89.91
26637162934 master connect: fix etcd connection for non admin users NewEtcdStorage checked the cluster status through the Maintenance.Status function, which requires root permissions. Replace it with MemberList (serializable), which is open to any authenticated use... push bigbes github
89.91
26520148948 master test_helpers/etcd: replace internal/testing/etcd embedded helper The old internal/testing/etcd helper was built on go.etcd.io/etcd/tests/v3, which drags in a v1 build of grpc-ecosystem/go-grpc-middleware and the pre-split google.golang.org/genpro... push bigbes github
89.95
26288689338 master integrity: add ValueKey/FullKeys with prefix-aware Store accessors Codec.ValueKey returns the namer-relative value-layer key (renamed from the originally-proposed FullKey). Codec.FullKeys returns every key the namer would emit for the name — valu... push bigbes github
89.91
26234582722 master locker: add Done/Do/Prefixed helpers and make Factory an interface Done() returns a channel closed when the Locker is no longer holding the lock — either after Unlock or when the backend session is lost (TTL elapsed without renewal, connection dr... push bigbes github
90.05
26233039368 master locker: add Locker interface package and wire NewLocker into Storage Add Locker (Lock/TryLock/Unlock/Key), Options + WithTTL + ApplyOptions, sentinel errors (ErrLocked, ErrSessionExpired, ErrLockReleased, ErrUnsupported), and DefaultTTL = 60s. Al... push bigbes github
90.03
26221122596 master integrity: add WithKeyPrefix option Add WithKeyPrefix option to namer.LayeredNamer and thread it through integrity.CodecBuilder so codecs can be built with a fixed path prefix prepended to every emitted/parsed key. - Let two codecs sit in disjoi... push bigbes github
89.99
26094001569 master driver/etcd: add concurrency-based Locker Locker wraps concurrency.NewSession + concurrency.NewMutex, which require the concrete *etcd.Client. NewLocker type-asserts the stored Client to *etcd.Client; drivers built with a non-concrete Client retu... push bigbes github
89.94
26027884314 master driver/dummy: add in-memory Locker In-process Locker backed by a sync.Mutex map keyed by name. Honors per-call and lifetime ctx cancellation. Intended for tests and single-process setups. Example covers acquire / TryLock contention / release. Bu... push bigbes github
93.24
26027891400 master driver/tcs: add Locker over config.storage "Smallest mod_revision wins" admission over config.storage.put / get / keepalive / delete, with a UUID fence and a ttl/3 keepalive ticker; on transport or session loss the locker fires ErrSessionExpired.... push bigbes github
89.74
See All Builds (291)