swinn-io / server

88%

master: 88%

LAST BUILD ON BRANCH feat/thread-ping-command

branch: feat/thread-ping-command

CHANGE BRANCH

x

Reset

Sync Branches

• feat/thread-ping-command
• chore/laravel-boost
• chore/php-linting-formatting
• chore/phpstan-burndown-1
• ci/seo-checkup
• dependabot/composer/guzzlehttp/guzzle-7.15.1
• dependabot/composer/guzzlehttp/guzzle-7.15.2
• dependabot/composer/league/commonmark-2.9.0
• dependabot/npm_and_yarn/postcss-8.5.25
• feat/laravel-nightwatch
• feat/reverb-broadcasting
• feat/reverb-hardening
• feat/socket-status-navbar
• feat/typed-payload-protocol
• feature/frontend-rebuild
• fix/login-todos
• fix/pdo-ssl-ca-deprecation
• fix/reverb-hardening-followups
• fix/telescope-migration-and-prune
• master
• update-license

Build # 29434827291

Build Type

Pull #86

github

Committed by ikidnapmyself

Commit Message

refactor: drop free-text note from ping (violated no-free-text convention)

Every message type in this app forbids free text (MoodType "No free
text", StatusType "not a notes field", etc.), so PingType's optional
prose `note` field was inconsistent. Removed the field, the --note
option, and the note-in-payload — the ping payload is now just
{user_ids}. That eliminated the only user-controlled value that could
make the envelope invalid, so the now-unreachable InvalidEnvelopeException
try/catch and renderEnvelopeError helper were removed too (the envelope
is valid by construction). Dropped the two note-max-length tests
accordingly.

Pull Request Pull Request #86: feat: thread:ping artisan command

Coverage Stats

79 of 79 new or added lines in 3 files covered. (100.0%)

732 of 836 relevant lines covered (87.56%)

13.67 hits per line