swinn-io / server / 29434827291

88%

master: 88%

Pull #86

github

refactor: drop free-text note from ping (violated no-free-text convention)

Every message type in this app forbids free text (MoodType "No free
text", StatusType "not a notes field", etc.), so PingType's optional
prose `note` field was inconsistent. Removed the field, the --note
option, and the note-in-payload — the ping payload is now just
{user_ids}. That eliminated the only user-controlled value that could
make the envelope invalid, so the now-unreachable InvalidEnvelopeException
try/catch and renderEnvelopeError helper were removed too (the envelope
is valid by construction). Dropped the two note-max-length tests
accordingly.

79 of 79 new or added lines in 3 files covered. (100.0%)

732 of 836 relevant lines covered (87.56%)

13.67 hits per line