sul-dlss / pre-assembly

58%

master: 92%

LAST BUILD ON BRANCH fix_build

branch: fix_build

CHANGE BRANCH

x

Reset

• fix_build
• 139-job-mailer
• 313_argo
• 330-jobrun-index-view
• 471-fix-workflow-call
• 525-reaccession
• 532-error-logging
• 743-agreement-accessioning
• 751-content-metadata-manifests
• AR-BundleContext
• SaravShah-patch-1
• add-3d-content-type
• add-3d-content-type-legacy
• add-bundle-path
• add-bundle_dir_root
• add-cap-resque-pool
• add-link-to-resque
• add-logging-to-discovery-report
• add-publish-attr
• add-qa
• add-rails-gem
• add-rubies-to-build
• add-user-info
• adjust-deployment
• all-public
• allow-deploy-to-lyberservices-XX-servers-from-master
• amcollie_600
• amcollie_609
• ar-bc-with-bundle
• ar-model-bc-bundle
• assembly-image
• assembly-staging-dir
• audio-feature-spec
• autoupdate-20200513224712
• avoid-deprecation
• avoid-nil-merge
• batch-not-bundle
• bc_buttons
• bc_init
• bc_show
• bc_uniqness
• bcc_new_not_index
• before_callbacks
• better-errs
• blalbrit-patch-1
• boot_fix
• bootstrap
• bump-cocina
• bundle_dir_staging
• bundle_spec
• bundle_usage_error
• bundlecontext-own-file
• bundler
• bundler-2.1.2
• cap-debug
• cap-deploy-functional
• changes-to-prepare-content-script
• checksum_bug
• circleci-codeclimate
• cleanup-csv-import-code
• client
• cocina
• cocina-level2-updates
• cocina-models
• comment_profile_examples
• config_client
• configuration-modeling
• content-tag-override
• content-tag-override-logic
• content_metadata_creator2
• coveralls
• cut_ties
• darkness
• database-yml_jm
• db-monitor
• dead-code
• defaults
• delete-cascade
• delete-empty-unused-production-settings
• dep-updates
• dependabot/bundler/kaminari-1.2.1
• dependabot/bundler/nokogiri-1.11.0
• dependabot/bundler/nokogiri-1.12.5
• dependabot/bundler/rack-2.0.8
• dependabot/bundler/rubyzip-1.3.0
• dependabot/bundler/websocket-extensions-0.1.5
• deploy
• deploy-fix
• deploy-honeyb-fix
• deployable
• deployed
• deployrb-fix
• desc-md-removal
• dev_cli_env
• devise
• devise-hookup
• devopsdocs-wants-status
• die-druid-minter
• digital_oobjects
• dis-rpt-svc-tweak
• disc-report-manual
• disc-rpt-job
• discovery-report-shrunk
• discovery_oo
• disentangle_assembly_dir
• do_not_call_cli_deprecated_437
• document
• dor-services
• dor-services7
• down_with_scope
• down_with_scope_2
• download_button
• dr-runnable
• dr_json
• dr_templates
• dsc-5
• enum_default
• excise-bctemp
• excluded-methods
• exists_exist
• experiment_over
• extract_assembly_directory
• field-validation-plumbing
• field-validation-plumbing_jm-rebase
• file-mv
• file_attr
• finished
• fix
• fix-sunet-id-test
• fix-typo
• fix_spec_network_call
• fixup
• form_not_yaml
• freeze
• get-files-from-stacks
• hb_erubis
• hb_haml_issues
• honeybadger
• image-feature-spec
• init
• init_fix_for_deploy
• invoke-wf-client-correctly
• janitorial_work
• jcoyne-patch-1
• job-history-active-record
• job-output-parent-dir
• job-run-views
• job_run_controller
• job_run_controller_views
• job_run_factory
• job_runs-toggle
• job_wire_up
• job_wiring
• jobs_jobs_jobs
• jobtype
• jobtype-toggle
• jobtype-validation
• legacy-updates
• let_let_be
• let_over_instance_vars
• line_endings
• lint_remover
• little-fixes
• load_rubo_for_env
• log-error
• mail_template
• main
• manifest_cols
• map-accessioning-script-updates
• markdown
• master
• master-to-main
• master_update_dsc_dsc#38
• media-not-smpl
• media-not-smpl_touchup
• mjgiarlo-patch-1
• moar_templatz
• more-test-data
• more_factories
• more_ok
• mount-resque-route
• move-exemplar-templates
• mow_the_yard
• mv_download_script
• naming
• ndushay-debug
• ndushay-patch-1
• no-modsulator
• no-monkeypatching
• no-roo
• no-techmd
• no-workers
• no_more_yaml_form
• no_remediation
• no_yuo_validate_files
• normalize-content-types
• o2p_cache
• object-finder
• object_files_exist
• objectfile_super
• ok-comment
• ok-test
• ok_computer
• okc-worker-check
• okcomp-queue-size
• okcomputer-redis
• old_dir_cleanup
• output-dir-again
• output-dir-integration
• output-dir-proj-name
• output-loc-spec-touchup
• pa-console-runnable
• pa_job
• path_validation_bundle_dir
• pin-rails-6.1
• pin-sassc-rails
• pr-template
• pre_assembly_root-last-excision
• prepare-content
• private
• protocol-https
• prune
• public-and-dark
• queue-depth
• quick_specs
• quiet-honeybadger
• rails-6
• rails-6.1
• rails7
• rails_root
• readme-update
• readme-updates
• readme_cuts
• readme_purge
• redirect_job_run_index
• reduce-darkness
• reduce-state
• released-shoulda-matchers
• remove-book-as-image
• remove-cli-env
• remove-container-writer
• remove-cruft
• remove-devel
• remove-hardcoded-paths
• remove-pids
• remove-run-robot
• remove-salt
• remove-unused-test-data
• remove_erubis_dependency_436
• remove_ruby_version
• remove_token_header
• rename-smoke-test
• rename-to-bundle-context
• require-dor-services-in-cli-envs
• require-workflow-service-in-legacy
• resque
• resque_deploy
• rm-stageable-discovery-ex-cfg
• rm_cli_env
• rm_cruft
• rm_file_attr
• robot2rails-env
• robots_env2rails_env
• rspec_rails
• rubocop
• rubocop-ci
• rubocop-rspec
• rubocop_4_real
• rubocop_ci
• ruboplop
• ruby3
• ruby_bump
• runknown
• settings-yml
• should_register_false
• shoulda
• shutup-honeybadger
• simplify_setup
• skipped_files
• small-refactors
• smpl-test-data
• smpl-test-data_jm-rebase
• smpl-to-media
• smpl-to-media-refs
• smpl_console_work
• sqlite
• stager
• standard-layout
• start-accession
• stub_expensive_test
• stubs
• sul-styles
• sunet-email
• t603-nil
• tech-md
• templatez
• test-disc-report
• test-fixup
• test-sunet
• time-zones
• todo-checkin
• travis-cache-bundler
• travis_env
• travis_exiftool
• ui-beginnings
• ui-beginnings-deployable
• ui-beginnings-rebased
• undo-user-email
• upd-dependencies
• upd-deps
• upd-deps-again
• update-badges
• update-cocina
• update-cocina-models
• update-dependencies
• update-dependencies-legacy
• update-dependencies-v3-legacy
• update-dor-services-on-legacy
• update-gem
• update-gitignore
• update-hb-env-for-legacy
• update-noko
• update-readme
• update-rubies
• update-ruby
• update-rubyzip
• update-rumsey-script
• update_cocina
• update_dsc
• upgrade-travis-node
• upgrade_deps
• use-default-deployed-ruby
• use-new-bc
• use-start-accession-endpoint
• use_attributes
• use_attributes_bundle
• use_dor_services_client_430
• use_dor_services_client_v3-legacy_430
• use_hot_swap
• user-cleanup
• user-model
• user_email_field
• v3-legacy
• v3-legacy-dep-updates
• v3-legacy-now-lyberservices-scripts-repo
• v3-legacy-readme-update
• v3-legacy-update
• v3-legacy-update-deps
• v3-update-dependencies
• v3.0.3
• validate-files-in-the-form-of-a-question
• validate_files_attr
• validations_bc
• version
• whitespace
• without-dor
• woop_woop

Build # 890

Build Type

Pull #289

travis-ci

Committed by web-flow

Commit Message

Tweak BundleContextController and rework tests

No need to separately `find_by` when rspec gives us the `assigns`
method.  It gives the tests access to the **same** object the template would
receive (even better than a different object -- or `nil` -- returned by
`find_by`).

Uses devise helper `sign_in` method and removes hardcoded `User.create`
in controller (meaning only one object could ever be created, since the
subsequent `User.create` would certainly fail).

Controller is not concerned with Job directly, only with creating a
`JobRun` object.

`current_user` is one of the `bundle_context_params`, logically.  Pass
it to `.create`.

`bundle_input_b` doesn't exist anymore, and the model still requires the
`bundle_dir` to exist to be valid (and saved). Changed it to `smpl_multimedia`.

This fixes the build.

Pull Request Pull Request #289: Tweak BundleContextController and rework tests

Run Details

4 of 4 new or added lines in 1 file covered. (100.0%)

528 of 912 relevant lines covered (57.89%)

15.01 hits per line