stores-com / petty-cache

100%

main: 100%

Pull #73

github

Invoke callbacks exactly once, outside of the promise chain

The callback bridge was executor().then(result => callback(null, result)).catch(callback),
so a callback that threw was caught by its own .catch and invoked a second time
with the error it had just thrown, while the original throw was swallowed
entirely. Bridge through process.nextTick instead, matching util.callbackify:
the callback is invoked exactly once, and a throw from within it surfaces as an
uncaught exception rather than rejecting a promise nobody owns.

Applies to all 17 callback-style call sites. The shape first appeared in 3.6.0
at 6 sites and grew to 9 in 3.7.0; 4.0.0 extended callback support to the rest
of the API and took the bug with it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

302 of 302 branches covered (100.0%)

Branch coverage included in aggregate %.

28 of 28 new or added lines in 1 file covered. (100.0%)

1118 of 1118 relevant lines covered (100.0%)

60.04 hits per line