sonirico / go-hyperliquid

18%

LAST BUILD ON BRANCH master

branch: SELECT

CHANGE BRANCH

x

Sync Branches

• No branch selected
• chore/remove-name-to-coin
• chore/types
• correct-msgpack-str16-str8-conversion
• dependabot/github_actions/actions/cache-5
• dependabot/github_actions/actions/cache-6
• dependabot/github_actions/actions/checkout-5
• dependabot/github_actions/actions/checkout-6
• dependabot/github_actions/actions/checkout-7
• dependabot/github_actions/actions/setup-go-6
• dependabot/github_actions/actions/setup-go-7
• dependabot/github_actions/akhilmhdh/contributors-readme-action-2.3.11
• dependabot/go_modules/github.com/ethereum/go-ethereum-1.16.0
• dependabot/go_modules/github.com/ethereum/go-ethereum-1.16.1
• dependabot/go_modules/github.com/ethereum/go-ethereum-1.16.3
• dependabot/go_modules/github.com/ethereum/go-ethereum-1.16.4
• dependabot/go_modules/github.com/ethereum/go-ethereum-1.16.5
• dependabot/go_modules/github.com/ethereum/go-ethereum-1.16.7
• dependabot/go_modules/github.com/ethereum/go-ethereum-1.16.8
• dependabot/go_modules/github.com/ethereum/go-ethereum-1.17.0
• dependabot/go_modules/github.com/ethereum/go-ethereum-1.17.1
• dependabot/go_modules/github.com/ethereum/go-ethereum-1.17.2
• dependabot/go_modules/github.com/ethereum/go-ethereum-1.17.3
• dependabot/go_modules/github.com/ethereum/go-ethereum-1.17.4
• dependabot/go_modules/github.com/ethereum/go-ethereum-1.17.5
• dependabot/go_modules/github.com/mailru/easyjson-0.9.2
• dependabot/go_modules/github.com/sonirico/vago-0.10.0
• dependabot/go_modules/github.com/sonirico/vago-0.11.4
• dependabot/go_modules/github.com/sonirico/vago-0.12.0
• dependabot/go_modules/github.com/sonirico/vago-0.7.3
• dependabot/go_modules/github.com/sonirico/vago-0.8.1
• dependabot/go_modules/github.com/sonirico/vago-0.9.0
• dependabot/go_modules/github.com/sonirico/vago/lol-0.1.0
• dependabot/go_modules/github.com/stretchr/testify-1.11.0
• dependabot/go_modules/github.com/stretchr/testify-1.11.1
• dependabot/go_modules/github.com/stretchr/testify-1.12.0
• dependabot/go_modules/github.com/stretchr/testify-1.12.1
• dependabot/go_modules/github.com/valyala/fastjson-1.6.10
• dependabot/go_modules/github.com/valyala/fastjson-1.6.7
• dependabot/go_modules/gopkg.in/dnaeon/go-vcr.v4-4.0.6
• dependabot/go_modules/gopkg.in/dnaeon/go-vcr.v4-4.0.7
• feat/add-user-non-funding-ledger-updates
• feat/add-vault-methods
• feat/aggregate-by-time
• feat/allmids
• feat/asset-info-new-fields
• feat/custom-client-options
• feat/debug-mode
• feat/export-order-types
• feat/hip3
• feat/notifications
• feat/open-order-cloid-origsz
• feat/perp-dexs
• feat/signer-di
• feat/subscribe-user-fills
• feat/user-active-asset-data
• feat/ws-active-asset-ctx
• feat/ws-endpoints-custom-hosts
• feat/ws-order-updates
• feat/ws-webdata2
• feature/add-reserve-request-weight-method
• feature/context
• feature/create-token-details-method
• feature/issue-18
• feature/nonce
• fix
• fix-update-isolated-margin-ntli-int
• fix/HIP3-markets-order-placing
• fix/add-security-checks
• fix/approve-agent-and-cloid-serialization
• fix/bulk-modify-orders-wiring
• fix/clearinghousestate-callback
• fix/context
• fix/fill-type
• fix/generate-types
• fix/hip3-responses
• fix/lint
• fix/missing-websocket-matchings
• fix/nonce
• fix/order-query-methods
• fix/order-type-wire
• fix/parse-meta-collateral-token
• fix/position-cumfunding
• fix/remove-log
• fix/reserve-weight-response-handling
• fix/sigfigs
• fix/slippage-price-silent-zero
• fix/slippage-rounding
• fix/spot-user-state
• fix/token-index
• fix/typing-meta-info
• fix/user-fills-subscription-type
• fix/userfees-missing-props
• fix/vaultaddr-response-parsing
• fix/websocket-deadlock
• fix/ws-candles
• fix/ws-read-timeout
• fix_orderstatusvalue
• halt-trading-method
• master
• refactor/context
• refactor/typed-modify-order-request
• refactor/ws
• remove-dispatch-pong-err-log
• set-oracle
• test/apiresponse-unmarshal
• test/exchange-orders-cancelbycloid
• test/meta-methods

Build # 33382103020

Build Type

push

github

Committed by web-flow

Commit Message

fix: don't silently use 0 when a wire price/size fails to parse (#172)

parseFloat returns 0.0 on any parse error. Two financial call sites relied
on it for values coming off the API:

- SlippagePrice (market order price): a malformed mid price became a market
  order priced at 0, with no error.
- MarketClose (position size): a malformed pos.Szi became size 0 (a no-op /
  wrong close).

Add parseFloatStrict (error-returning) and use it at both sites, which both
already return an error. parseFloat is unchanged for its display callers, so
this is non-breaking. Adds a unit test contrasting the two parsers.

Coverage Stats

6 of 14 new or added lines in 3 files covered. (42.86%)

4111 of 23263 relevant lines covered (17.67%)

330.5 hits per line