sjlongland / aioax25
100%
master: 100%

LAST BUILD BRANCH: bugfix/ghi24-va-state-advance
DEFAULT BRANCH: master
Repo Added
Files 25
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH bugfix/ghi24-va-state-advance
branch: SELECT
CHANGE BRANCH
x

coverage: 99.821% (-0.2%) from 100.0%
25590716031

push

github

sjlongland 
GHI24: peer: Ensure advancement of V(A)

- If `N(R) - 1` (given as `nr` here) is equal to `V(A)`, then
  acknowledge `N(R) - 1`.
- If we have no frames to acknowledge, break out of the loop to avoid
  unnecessarily stepping through the whole sequence.
- Increment at the end unconditionally to ensure `V(A) - 1` is equal
  to `N(R)`.

379 of 379 branches covered (100.0%)

Branch coverage included in aggregate %.

4 of 11 new or added lines in 1 file covered. (36.36%)

3535 of 3542 relevant lines covered (99.8%)

5.99 hits per line

Relevant lines Covered
3542 RELEVANT LINES 3535 COVERED LINES
5.99 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
25590716031 bugfix/ghi24-va-state-advance GHI24: peer: Ensure advancement of V(A) - If `N(R) - 1` (given as `nr` here) is equal to `V(A)`, then acknowledge `N(R) - 1`. - If we have no frames to acknowledge, break out of the loop to avoid unnecessarily stepping through the whole seque... push sjlongland github
99.82
25590707390 master aprs.message: Handle CR on ACK/REJ The Yaesu FT5-DR emits the carriage return on the end of the ACK/REJ. This has not been observed on other devices. push sjlongland github
100.0
24927325362 bugfix/ghi24-va-state-advance GHI24: peer: Ensure advancement of V(A) - If `N(R) - 1` (given as `nr` here) is equal to `V(A)`, then acknowledge `N(R) - 1`. - If we have no frames to acknowledge, break out of the loop to avoid unnecessarily stepping through the whole seque... push sjlongland github
99.82
24325400226 master Merge branches 'bugfix/i-frames-are-commands' and 'bugfix/station-cleanup' push sjlongland github
100.0
24238951517 bugfix/i-frames-are-commands GHI23: peer: Auto-downgrade to AX.25 1.0 if matching C/R bits observed If we do not explicitly know the version of AX.25 being used, and they send us a frame with matching bits, assume it is a v1.0 station. No idea how v1.0 differs from v2.0 oth... push sjlongland github
100.0
24237689699 bugfix/station-cleanup GHI29: peer: Clean up timers if the station disappears `weakref.ref()` can take a callback that notifies us that the referenced object is about to disappear. While we could add guards to all the functions that will barf without a station, the is... push sjlongland github
100.0
24237009267 bugfix/i-frames-are-commands GHI23: peer: Set S-frame and U-frame C/R bits Not completely sure how these should be set, but given how I-frames are described in the AX.25 docs, I've applied the same logic to S-frames and U-frames. By being explicit, it should make it obvious... push sjlongland github
100.0
24236025703 bugfix/i-frames-are-commands GHI23: peer: Apply C/R changes for S-frames too These presumably need to be set correctly too. push sjlongland github
100.0
24229747508 bugfix/i-frames-are-commands GHI23: peer: Send I-frames as commands It's not explicitly stated anywhere in either AX.25 2.0 or 2.2, but it appears many AX.25 implementations expect I-frames to be sent as "commands". Test that this in fact is the case. push sjlongland github
100.0
24222323282 master README.md: Fix broken link push sjlongland github
100.0
See All Builds (348)