shoes / shoes4

91%

master: %

LAST BUILD ON BRANCH text_width_handling

branch: text_width_handling

CHANGE BRANCH

x

Reset

• text_width_handling
• app-proxy
• app-proxy_rake
• button_displace_style
• changelog
• clear_after_dispose
• clear_links
• clear_transform
• click_proc
• context
• cursor_revision
• daniel_fix
• displace
• displace_fix
• dispose
• dispose_text
• experimental_text_block_flow
• explicit_width_crash
• extract-dimension-from-dimensions
• fi/built_in_methods
• fi/click_option
• fi/clipboard_spec_tests
• fi/console
• fi/curate_samples
• fi/display_underlines
• fi/mac_persistence_error
• fi/nested_styles
• fi/new_span
• fi/rake_task_create_list_of_non_samples
• fi/rise_text_style
• fi/scrolling_increment_value
• fi/set_underline_color
• fi/shoesp
• fi/span
• fi/strikethrough
• fi/swt_text_bock_refactor
• fi/text_block_painter_refactor
• fi/text_block_refactoring
• fi/weight_and_emphasis
• fitting_outside_containers
• fix-off-by-one
• gem_installation
• gems
• global_keypress
• good_vjot
• guard-jruby-rspec
• gutter
• image_dispose
• implement_contents
• inspect
• leak_hunter
• leak_hunter_keypress
• leaking_colors
• left_top_reporting
• link_bounds
• link_click_option
• mad_flow
• margins_on_text_blocks
• master
• more_accurate_redraws
• move-helpers
• next_dir_problem_on_gem
• no-file-error
• painter_alert_fail
• pairwithme_for_a_better_dsl
• para_clicking
• rake_samples
• rake_spec_isolate_suites
• readme_changes_for_release
• redraw_only_on_style_update
• refactor-swt-context
• refactor-swt-specs
• refactor_dsl_spec
• refactor_url
• remove_manual_flush
• removing_moving_next
• replace_method_missing
• revert-rspec3
• revise_sample35
• right_and_bottom
• rspec3
• rubocop
• scroll
• shape-dimensions
• simple-menu-fixes
• stale_textcursor
• style-for-elements
• subdir_for_text_block
• swtUpdateTry
• swt_shared_context
• text_block_dimensions
• text_cursor_tidy
• text_flow_tidying
• toggles_everywhere
• transform_dispose
• travis_bouncy-castle-java-fix
• unless-disposed-delegator
• v4.0.0.pre1
• widget_app_delegation

Build # 1103

Build Type

push

travis-ci

Committed by jasonrclark

Commit Message

Remove incorrect sizing methods for text block

The original text block implementation had a bad design where the sizes were
asked immediately from the SWT version before anything had been fitted. With
text flowing, that can't give the right answer any longer.

This commit removes that cruft, and at least one nil check along the way that
became superflous with that code gone.

Things are generally working, although the text block DSL now lacks the
proper dimensions which will get resolved in a later commit.

Run Details

3170 of 3479 relevant lines covered (91.12%)

648.16 hits per line