shoes / shoes4

93%

master: %

LAST BUILD ON BRANCH para_clicking

branch: para_clicking

CHANGE BRANCH

x

Reset

• para_clicking
• app-proxy
• app-proxy_rake
• button_displace_style
• changelog
• clear_after_dispose
• clear_links
• clear_transform
• click_proc
• context
• cursor_revision
• daniel_fix
• displace
• displace_fix
• dispose
• dispose_text
• experimental_text_block_flow
• explicit_width_crash
• extract-dimension-from-dimensions
• fi/built_in_methods
• fi/click_option
• fi/clipboard_spec_tests
• fi/console
• fi/curate_samples
• fi/display_underlines
• fi/mac_persistence_error
• fi/nested_styles
• fi/new_span
• fi/rake_task_create_list_of_non_samples
• fi/rise_text_style
• fi/scrolling_increment_value
• fi/set_underline_color
• fi/shoesp
• fi/span
• fi/strikethrough
• fi/swt_text_bock_refactor
• fi/text_block_painter_refactor
• fi/text_block_refactoring
• fi/weight_and_emphasis
• fitting_outside_containers
• fix-off-by-one
• gem_installation
• gems
• global_keypress
• good_vjot
• guard-jruby-rspec
• gutter
• image_dispose
• implement_contents
• inspect
• leak_hunter
• leak_hunter_keypress
• leaking_colors
• left_top_reporting
• link_bounds
• link_click_option
• mad_flow
• margins_on_text_blocks
• master
• more_accurate_redraws
• move-helpers
• next_dir_problem_on_gem
• no-file-error
• painter_alert_fail
• pairwithme_for_a_better_dsl
• rake_samples
• rake_spec_isolate_suites
• readme_changes_for_release
• redraw_only_on_style_update
• refactor-swt-context
• refactor-swt-specs
• refactor_dsl_spec
• refactor_url
• remove_manual_flush
• removing_moving_next
• replace_method_missing
• revert-rspec3
• revise_sample35
• right_and_bottom
• rspec3
• rubocop
• scroll
• shape-dimensions
• simple-menu-fixes
• stale_textcursor
• style-for-elements
• subdir_for_text_block
• swtUpdateTry
• swt_shared_context
• text_block_dimensions
• text_cursor_tidy
• text_flow_tidying
• text_width_handling
• toggles_everywhere
• transform_dispose
• travis_bouncy-castle-java-fix
• unless-disposed-delegator
• v4.0.0.pre1
• widget_app_delegation

Build # 1318

Build Type

push

travis-ci

Committed by jasonrclark

Commit Message

Safer in_bounds? check

Original version of the bounds checking was, for whatever strange reason
made sense to me at the time, modifying the bounds we got back to do a
contains? check. This is odd and potentially hazardous (if layouts
didn't return a clean copy of bounds).

Additionally in reviewing it, I realized the logic fit much more cleanly
within the FittedTextLayout class itself, so I moved it along with
removing the strangeness.

Run Details

3500 of 3775 relevant lines covered (92.72%)

698.93 hits per line