sergi / go-diff

98%

master: 99%

LAST BUILD ON BRANCH 46-refactor-diffHalfMatchI-and-remove-concat

branch: 46-refactor-diffHalfMatchI-and-remove-concat

CHANGE BRANCH

x

Reset

• 46-refactor-diffHalfMatchI-and-remove-concat
• 19-DiffCleanupSemantic
• 21-invalid-utf8
• 27-refactor-DiffCleanupMerge-to-use-runes-instead-of-strings
• 28-handle-zero-deadlines-differently
• 29-diff-equals-must-be-equal-to-originals
• 32-fixed-bug-in-overlap-elimination
• 43-refactor
• master
• migrate-to-github.com/stretchrcom/testify
• remove-assertMapEqual-in-favor-of-assert.Equal
• remove-the-stack-implementation
• revamp-the-readme
• support-1.6-and-1.7
• travis-coveralls-linters

Build # 32

Build Type

push

travis-ci

Committed by zimmski

Commit Message

Refactor diffHalfMatchI and remove concat

- The variable j is just a loop index so use a for-loop
- Most indentations can be removed by doing early-exits
- By doing the concatenating of bestCommon later we can often save lots
of cycles
- "concat" is useless since in most parts of the code, it isn't used
either

Fixes #46

Run Details

29 of 29 new or added lines in 1 file covered. (100.0%)

1681 of 1711 relevant lines covered (98.25%)

31611.95 hits per line