sergi / go-diff

98%

master: 99%

LAST BUILD ON BRANCH 27-refactor-DiffCleanupMerge-to-use-runes-instead-of-strings

branch: 27-refactor-DiffCleanupMerge-to-use-runes-instead-of-strings

CHANGE BRANCH

x

Reset

• 27-refactor-DiffCleanupMerge-to-use-runes-instead-of-strings
• 19-DiffCleanupSemantic
• 21-invalid-utf8
• 28-handle-zero-deadlines-differently
• 29-diff-equals-must-be-equal-to-originals
• 32-fixed-bug-in-overlap-elimination
• 43-refactor
• 46-refactor-diffHalfMatchI-and-remove-concat
• master
• migrate-to-github.com/stretchrcom/testify
• remove-assertMapEqual-in-favor-of-assert.Equal
• remove-the-stack-implementation
• revamp-the-readme
• support-1.6-and-1.7
• travis-coveralls-linters

Build # 23

Build Type

push

travis-ci

Committed by zimmski

Commit Message

Fix unicode splitting bug.

The old code finds prefixes/suffixes by rune index but splits strings at
byte index instead. This can split unicode chars into invalid chars for
large files and can cause panics in diffCharsToLines later on when
lookup is done on the invalid runes.

Run Details

15 of 15 new or added lines in 1 file covered. (100.0%)

1687 of 1725 relevant lines covered (97.8%)

31354.75 hits per line