scrapy / scrapy

LAST BUILD ON BRANCH singleton_removal

branch: singleton_removal

CHANGE BRANCH

x

Reset

• singleton_removal
• master
• 0.16
• codecov
• feature-1371-download-prios
• py3-fixes
• py3-linkextractors
• py3-middlewares
• twisted-15.4
• dupefilter-persist

Build # 37

Build Type

push

travis-ci

Committed by pablohoffman

Commit Message

Removed signals/stats singletons

This change removes singletons for stats collection and signal
dispatching facilities, by making them a member of the Crawler class.

Here are some examples to illustrates the old and new API:

Signals - before:

    from scrapy import signals
    from scrapy.xlib.pydispatch import dispatcher
    dispatcher.connect(self.spider_opened, signals.spider_opened)

Signals - now:

    from scrapy import signals
    crawler.signals.connect(self.spider.opened, signals.spider_opened)

Stats collection - before:

    from scrapy.stats import stats
    stats.inc_value('foo')

Stats collection - now:

    crawler.stats.inc_value('foo')

Backwards compatibility was retained as much as possible and the old API
has been properly flagged with deprecation warnings.

Run Details