scrapy / scrapy / 37

Ran 07 Nov 2013 10:22AM UTC

Jobs 1

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 37

Build Type

push

travis-ci

Committed by

pablohoffman

Commit Message

Removed signals/stats singletons

This change removes singletons for stats collection and signal
dispatching facilities, by making them a member of the Crawler class.

Here are some examples to illustrates the old and new API:

Signals - before:

    from scrapy import signals
    from scrapy.xlib.pydispatch import dispatcher
    dispatcher.connect(self.spider_opened, signals.spider_opened)

Signals - now:

    from scrapy import signals
    crawler.signals.connect(self.spider.opened, signals.spider_opened)

Stats collection - before:

    from scrapy.stats import stats
    stats.inc_value('foo')

Stats collection - now:

    crawler.stats.inc_value('foo')

Backwards compatibility was retained as much as possible and the old API
has been properly flagged with deprecation warnings.

Run Details

Jobs

ID	Job ID	Ran	Files	Coverage
6	37.6 (BUILDENV=latest)	07 Nov 2013 10:22AM UTC	0		Travis Job 37.6

Source Files on build 37

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

scrapy / scrapy / 37

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 37

scrapy / scrapy / 37

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 37

README BADGES
x