samsarahq / taskrunner

53%

master: 45%

LAST BUILD ON BRANCH tonia/runwithgo

branch: tonia/runwithgo

CHANGE BRANCH

x

Reset

• tonia/runwithgo
• ashaw/go_builder
• bf/add-travis
• bf/annotations
• bf/better-api
• bf/better-logging-for-goextensions
• bf/bugfixes
• bf/fix-datarace
• bf/persistent-invalidation-cache
• bf/tui
• changping/gqltaskrunner
• danhansen/fix-watcher-panic
• datadog_usage_monitoring
• denbeigh/hack-modules-build
• dependabot/go_modules/golang.org/x/crypto-0.1.0
• dependabot/go_modules/golang.org/x/net-0.7.0
• dependabot/go_modules/golang.org/x/sys-0.1.0
• dschofie/listall
• dschofie/models-combine
• jelle/watch
• jesse/add-license
• jesse/description
• jesse/extension
• jesse/isgroup
• jesse/taskrunner-help
• johnkim/add-owner-field-to-task
• johnkim/failOnAnyInvalidTask
• johnkim/go1.17
• johnkim/handle-sighup
• jsm/shell-run-options
• master
• mdb/dynamically-set-up-go-in-ci
• pass-cl-args-to-tasks
• samloop/add-taskrunner-owners-to-annotations
• samloop/improve-runner-logging
• samloop/test
• samloop/update-github-actions
• sara/task_description
• shane/line-buffer-output
• shaunhoulihan/goupdate
• shaunhoulihan/readable
• simon/add-warning-option
• stephen-patch-1
• stephen/config-rewrite
• stephen/execs
• stephen/fixes
• stephen/propagate
• stephen/remove-livelogger
• stephen/stdout-option
• tonia/fix-flags-to-tr
• tonia/fix-silent-runner-task-invalidation
• tonia/logf
• tonia/support-task-flags
• tonia/support-task-options
• tonia/validate-tasks-in-runner
• wh/symboliclinks/part-1.0
• zack/update-node-modules

Build # 5226848516

Build Type

push

github

Committed by toniihsia

Commit Message

taskrunner goextensions builder: define RunWithFlags

The purpose of `WrapWithGoBuild` is to ensure that that a specified
Go package can build before running the logic passed in `Run`.

`WrapWithGoBuild` does this by cloning the original task, then overwriting
the `Run` fn to first build the specified package  before running any logic
defined in the task's original `Run`.

Notably, `WrapWithGoBuild` defines a `Run` fn on the cloned task regardless
of whether `Run` is defined on the original task.

For tasks that are both:
* wrapped with `WrapWithGoBuild`
* leveraging `RunWithFlags`
this causes a bug to occur where `WrapWithGoBuild`'s cloned task has both
a `Run` fn and a `RunWithFlags` fn.
Both being defined causes the registry to return an error about only
allowing one or the other to be defined.

Update `WrapWithGoBuild` to only define a `Run` fn on the cloned task
if a `Run` fn was included in the original task. Otherwise, default to
defining `RunWithFlags` since `Run` has been deprecated in favor of `RunWithFlags`.

Run Details

730 of 1388 relevant lines covered (52.59%)

4.79 hits per line