rytilahti / python-miio
72%
master: 74%

LAST BUILD BRANCH: fix/bump_cryptography_dep
DEFAULT BRANCH: master
Repo Added
Files 47
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH revise_broadcast_discovery
branch: revise_broadcast_discovery
CHANGE BRANCH
x

1108

push

travis-ci

rytilahti 
Revise device (broadcast-using) discovery process

This is the initial commit to rework the handshake/discovery process,
separating them to separate entities.

The discovery part from Device class is moved into MiIODiscovery class usable for broadcast discovery of available devices.
Also, instead of printing out the details from discovered devices, a list of Devices is being returned.
The discover() method of the class is extended to allow discovery on all network interfaces (instead of using 255.255.255.255),
making it easier to perform the initial configuration of non-provisioned devices and/or work with devices in other subnets.

Although the change cause some duplicate code (mainly the handshake payload),
this will make the responsibilities of corresponding classes clearer and code more usable for 3rd party developers.

There will be cleanups and (likely also) renamings of some of the parts, but I wanted to make
this available for others to comment.

TODO:
* Upcasting the Device to a corresponding implementation class (miIO.info model information could be useful, too..)
* Decide how to handle the returning of discovered devices. Use a separate DiscoveredDevice class which can be used
  to initialize the real device, or use the existing Device and do the casting trick?

Related to #152 (and maybe #422).

400 of 716 branches covered (55.87%)

Branch coverage included in aggregate %.

2667 of 3545 relevant lines covered (75.23%)

1.5 hits per line

Relevant lines Covered
3545 RELEVANT LINES 2667 COVERED LINES
1.5 HITS PER LINE
Source Files on revise_broadcast_discovery
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
1108 revise_broadcast_discovery Revise device (broadcast-using) discovery process This is the initial commit to rework the handshake/discovery process, separating them to separate entities. The discovery part from Device class is moved into MiIODiscovery class usable for broad... push rytilahti travis-ci pending completion  
1109 revise_broadcast_discovery Revise device (broadcast-using) discovery process This is the initial commit to rework the handshake/discovery process, separating them to separate entities. The discovery part from Device class is moved into MiIODiscovery class usable for broad... Pull #437 web-flow travis-ci pending completion  
See All Builds (1672)