• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

rytilahti / python-miio / 1109
72%
master: 74%

Build:
Build:
LAST BUILD BRANCH: fix/bump_cryptography_dep
DEFAULT BRANCH: master
Ran 12 Dec 2018 07:29PM UTC
Jobs 1
Files 29
Run time 7s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
1109

Pull #437

travis-ci

web-flow
Revise device (broadcast-using) discovery process

This is the initial commit to rework the handshake/discovery process,
separating them to separate entities.

The discovery part from Device class is moved into MiIODiscovery class usable for broadcast discovery of available devices.
Also, instead of printing out the details from discovered devices, a list of Devices is being returned.
The discover() method of the class is extended to allow discovery on all network interfaces (instead of using 255.255.255.255),
making it easier to perform the initial configuration of non-provisioned devices and/or work with devices in other subnets.

Although the change cause some duplicate code (mainly the handshake payload),
this will make the responsibilities of corresponding classes clearer and code more usable for 3rd party developers.

There will be cleanups and (likely also) renamings of some of the parts, but I wanted to make
this available for others to comment.

TODO:
* Upcasting the Device to a corresponding implementation class (miIO.info model information could be useful, too..)
* Decide how to handle the returning of discovered devices. Use a separate DiscoveredDevice class which can be used
  to initialize the real device, or use the existing Device and do the casting trick?

Related to #152 (and maybe #422).
Pull Request #437: Revise device (broadcast-using) discovery process

502 of 818 branches covered (61.37%)

Branch coverage included in aggregate %.

86 of 86 new or added lines in 2 files covered. (100.0%)

2667 of 3545 relevant lines covered (75.23%)

0.75 hits per line

Jobs
ID Job ID Ran Files Coverage
2 1109.2 12 Dec 2018 07:29PM UTC 0
72.63
Travis Job 1109.2
Source Files on build 1109
  • Tree
  • List 0
  • Changed 2
  • Source Changed 2
  • Coverage Changed 2
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Repo
  • Travis Build #1109
  • Pull Request #437
  • PR Base - master (#1106)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc