ruby-grape / grape
97%
master: 97%

LAST BUILD BRANCH: chore/prune-requires
DEFAULT BRANCH: master
Repo Added
Files 164
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH refactor/de-morgan-conditions
branch: refactor/de-morgan-conditions
CHANGE BRANCH
x

coverage: 97.038% (+0.02%) from 97.016%
25718275691

Pull #2707

github

ericproulx 
Tighten six guard conditions via De Morgan / blank? / present? / include?

Six spots where an `if`/`unless` clause used multiple negations
joined by `&&` or `||`, or `&.any?` on a Hash. Each rewrite expresses
the positive shape of the predicate and keeps `if` over `unless`
where natural. Same behaviour, same allocation profile (one form
even reuses a previously-recomputed `Hash#except` result).

* `Grape::API::Boolean.build` —
  `val != true && val != false` → frozen `VALUES` constant +
  `unless VALUES.include?(val)`.

* `Grape::Request#make_params` —
  `routing_args&.any? { |k, _| k != :version && k != :route_info }` +
  separate `routing_args.except(:version, :route_info)` two lines
  later → compute `except` once, gate on `filtered.blank?`.

* `Grape::Validations::ParamsScope#check_incompatible_option_values`
  (early guard) —
  `return unless default && !default.is_a?(Proc)` →
  `return if default.nil? || default.is_a?(Proc)`.

* `Grape::Validations::ParamsScope#check_incompatible_option_values`
  (raise condition) —
  `!Array(default).all? { |v| values.include?(v) }` →
  `Array(default).any? { |v| !values.include?(v) }`.

* `Grape::Validations::Validators::Base#scrub` —
  `unless value.respond_to?(:valid_encoding?) && !value.valid_encoding?`
  → `if !value.respond_to?(:valid_encoding?) || value.valid_encoding?`.

* `Grape::DSL::Routing#route` —
  `route_options&.any?` → `route_options.present?`.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Pull Request #2707: Tighten six guard conditions via De Morgan / blank? / present? / include?

1096 of 1179 branches covered (92.96%)

Branch coverage included in aggregate %.

10 of 10 new or added lines in 5 files covered. (100.0%)

3457 of 3513 relevant lines covered (98.41%)

32012.8 hits per line

Relevant lines Covered
3513 RELEVANT LINES 3457 COVERED LINES
32012.8 HITS PER LINE
Source Files on refactor/de-morgan-conditions

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
25718275691 refactor/de-morgan-conditions Tighten six guard conditions via De Morgan / blank? / present? / include? Six spots where an `if`/`unless` clause used multiple negations joined by `&&` or `||`, or `&.any?` on a Hash. Each rewrite expresses the positive shape of the predicate an... Pull #2707 ericproulx github
97.04
25610885355 refactor/de-morgan-conditions Tighten six guard conditions via De Morgan / blank? / present? / include? Six spots where an `if`/`unless` clause used multiple negations joined by `&&` or `||`, or `&.any?` on a Hash. Each rewrite expresses the positive shape of the predicate an... Pull #2707 ericproulx github
97.01
25610832363 refactor/de-morgan-conditions Tighten five guard conditions via De Morgan / blank? / include? Five spots where an `if`/`unless` clause used multiple negations joined by `&&` or `||`. Each rewrite expresses the positive shape of the predicate and keeps `if` over `unless` where... Pull #2707 ericproulx github
96.99
25610816166 refactor/de-morgan-conditions Merge 28a97e1ab into 037476e62 Pull #2707 web-flow github
96.99
25610805204 refactor/de-morgan-conditions Tighten five guard conditions via De Morgan / blank? / include? Five spots where an `if`/`unless` clause used multiple negations joined by `&&` or `||`. Each rewrite expresses the positive shape of the predicate and keeps `if` over `unless` where... push ericproulx github
96.99
See All Builds (3025)