ruby-grape / grape
97%
master: 97%

LAST BUILD BRANCH: perf/build-headers-each-header
DEFAULT BRANCH: master
Repo Added
Files 167
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH perf/router-transaction-no-proc
branch: perf/router-transaction-no-proc
CHANGE BRANCH
x

coverage: 96.983% (-0.02%) from 97.001%
24754788427

Pull #2692

github

ericproulx 
Replace per-request Proc in Router#transaction with a helper method

The `cascade_or_return_response` proc inside `Router#transaction` was
allocated on every request because it relied on non-local `return` to
exit the enclosing method when a non-cascading response arrived. That
behavior was doing two things at once — closing the cascading body as
a side effect, and halting transaction processing.

Split them: a plain `halt?(response)` helper returns `true` when the
response is final (and should be returned as-is), `false` when it's
either absent or cascading; closing the body lives inside the helper
as a side effect. The `transaction` method then uses explicit
early-returns for the halt case and plain assignments for the cascade
flag.

                      current     variant    speedup     alloc
cascading response    3.12 M/s    6.88 M/s   2.21x      1 → 0 objects
hit response (final)  3.07 M/s    9.82 M/s   3.20x      1 → 0 objects
nil response          5.07 M/s    15.7 M/s   3.10x      1 → 0 objects

Saves one proc allocation per request in the router's `transaction`
dispatch — plus 2–3x faster control flow in the cascade-decision step.

No behavior change; all 2,236 specs pass.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Pull Request #2692: Replace per-request Proc in Router#transaction with a helper

1079 of 1163 branches covered (92.78%)

Branch coverage included in aggregate %.

10 of 11 new or added lines in 1 file covered. (90.91%)

3357 of 3411 relevant lines covered (98.42%)

32161.49 hits per line

Relevant lines Covered
3411 RELEVANT LINES 3357 COVERED LINES
32161.49 HITS PER LINE
Source Files on perf/router-transaction-no-proc

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
24754788427 perf/router-transaction-no-proc Replace per-request Proc in Router#transaction with a helper method The `cascade_or_return_response` proc inside `Router#transaction` was allocated on every request because it relied on non-local `return` to exit the enclosing method when a non-c... Pull #2692 ericproulx github
96.98
24722053791 perf/router-transaction-no-proc Replace per-request Proc in Router#transaction with a helper method The `cascade_or_return_response` proc inside `Router#transaction` was allocated on every request because it relied on non-local `return` to exit the enclosing method when a non-c... Pull #2692 ericproulx github
96.98
24722037377 perf/router-transaction-no-proc Replace per-request Proc in Router#transaction with a helper method The `cascade_or_return_response` proc inside `Router#transaction` was allocated on every request because it relied on non-local `return` to exit the enclosing method when a non-c... Pull #2692 ericproulx github
96.98
See All Builds (3142)