ruby-grape / grape
97%
master: 97%

LAST BUILD BRANCH: perf/routing-args-in-place-merge
DEFAULT BRANCH: master
Repo Added
Files 166
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH perf/instrument-only-when-subscribed
branch: perf/instrument-only-when-subscribed
CHANGE BRANCH
x

coverage: 96.838% (-0.02%) from 96.861%
26721499467

Pull #2752

github

ericproulx 
Skip per-request instrumentation work when no subscribers are listening

Grape fires up to six ActiveSupport::Notifications.instrument calls per
request (endpoint run / render / run_validators / run_filters and
format_response). Each builds a payload Hash and enters the notification
machinery on every request, even when nothing is subscribed to the event.

Guard each emission behind ActiveSupport::Notifications.notifier.listening?
via a small private instrument_<event> method on the owning class. With no
subscriber the block runs directly, skipping the payload Hash and the
instrument dispatch; the block is forwarded anonymously so nothing extra is
allocated unless a subscriber is present. Behaviour is unchanged when a
subscriber exists - same events, same payloads.

Saves one Hash allocation per emitted event (-6 allocations/request on an
endpoint with before/after filters and params), ~+4.6% median throughput
under YJIT on that endpoint; scales with events emitted per request.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pull Request #2752: Skip per-request instrumentation work when no subscribers are listening

1112 of 1203 branches covered (92.44%)

Branch coverage included in aggregate %.

19 of 20 new or added lines in 2 files covered. (95.0%)

1 existing line in 1 file now uncovered.

3543 of 3604 relevant lines covered (98.31%)

23213.33 hits per line

Relevant lines Covered
3604 RELEVANT LINES 3543 COVERED LINES
23213.33 HITS PER LINE
Source Files on perf/instrument-only-when-subscribed

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
26721499467 perf/instrument-only-when-subscribed Skip per-request instrumentation work when no subscribers are listening Grape fires up to six ActiveSupport::Notifications.instrument calls per request (endpoint run / render / run_validators / run_filters and format_response). Each builds a payl... Pull #2752 ericproulx github
96.84
26721441528 perf/instrument-only-when-subscribed Merge 4ecad51b8 into 2e6b29db4 Pull #2752 web-flow github
96.84
26721434661 perf/instrument-only-when-subscribed Skip per-request instrumentation work when no subscribers are listening Grape fires up to six ActiveSupport::Notifications.instrument calls per request (endpoint run / render / run_validators / run_filters and format_response). Each builds a payl... push ericproulx github
96.84
See All Builds (3084)