Build has been canceled!

ruby-grape / grape
97%
master: 97%

LAST BUILD BRANCH: perf/build-headers-each-header
DEFAULT BRANCH: master
Repo Added
Files 167
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH fix/2763-multijson-deprecations
branch: fix/2763-multijson-deprecations
CHANGE BRANCH
x

coverage: 96.586% (-0.03%) from 96.616%
27497052435

Pull #2764

github

ericproulx 
Route Grape::Json through the non-deprecated MultiJSON API

multi_json 1.21.0 deprecated the `MultiJson` constant (in favor of
`MultiJSON`) and `MultiJSON.dump` (in favor of `generate`), removed in
2.0. Grape detected the backend via `::MultiJson` and called `dump`, so
users on multi_json >= 1.21 saw deprecation warnings (#2763).

Detect `::MultiJSON` and give `Grape::Json` a small facade whose `dump`
delegates to `MultiJSON.generate` (byte-identical output), re-exposing
`parse` since the facade no longer inherits MultiJSON's methods. Behavior
is unchanged; the stdlib fallback is untouched.

Following #2762 (Grape standardizes on `parse`, never `load`, for JSON),
the two remaining `Grape::Json.load` spec helpers move to `parse`, so
`Grape::Json.load` no longer appears anywhere and the facade needs no
`load`.

Also give the legacy multi_json (< 1.21) branch the same facade treatment
mapping dump/parse onto the dump/load it exposes — it has no generate/parse,
so `Grape::Json.parse` would otherwise raise NoMethodError there.

Cover both backends in CI: pin gemfiles/multi_json.gemfile to >= 1.21 and
add gemfiles/multi_json_1_20.gemfile (< 1.21), each running the
spec/integration/multi_json suite. The integration spec keys off the
`MultiJson` constant (defined on both lines) and drives a real Grape API
through the parser and JSON formatter.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pull Request #2764: Route Grape::Json through the non-deprecated MultiJSON API

1123 of 1221 branches covered (91.97%)

Branch coverage included in aggregate %.

14 of 16 new or added lines in 1 file covered. (87.5%)

3573 of 3641 relevant lines covered (98.13%)

23043.39 hits per line

Relevant lines Covered
3641 RELEVANT LINES 3573 COVERED LINES
23043.39 HITS PER LINE
Source Files on fix/2763-multijson-deprecations

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
27497052435 fix/2763-multijson-deprecations Route Grape::Json through the non-deprecated MultiJSON API multi_json 1.21.0 deprecated the `MultiJson` constant (in favor of `MultiJSON`) and `MultiJSON.dump` (in favor of `generate`), removed in 2.0. Grape detected the backend via `::MultiJson`... Pull #2764 ericproulx github
96.59
27496580206 fix/2763-multijson-deprecations Route Grape::Json through the non-deprecated MultiJSON API multi_json 1.21.0 deprecated the `MultiJson` constant (in favor of `MultiJSON`) and `MultiJSON.dump` (in favor of `generate`), removed in 2.0. Grape detected the backend via `::MultiJson`... Pull #2764 ericproulx github
96.59
27496510831 fix/2763-multijson-deprecations Route Grape::Json through the non-deprecated MultiJSON API multi_json 1.21.0 deprecated the `MultiJson` constant (in favor of `MultiJSON`) and `MultiJSON.dump` (in favor of `generate`), removed in 2.0. Grape detected the backend via `::MultiJson`... Pull #2764 ericproulx github
96.59
27496348267 fix/2763-multijson-deprecations Route Grape::Json through the non-deprecated MultiJSON API multi_json 1.21.0 deprecated the `MultiJson` constant (in favor of `MultiJSON`) and `MultiJSON.dump` (in favor of `generate`), removed in 2.0. Grape detected the backend via `::MultiJson`... Pull #2764 ericproulx github
96.46
27480306073 fix/2763-multijson-deprecations Route Grape::Json through the non-deprecated MultiJSON API multi_json 1.21.0 deprecated the `MultiJson` constant (in favor of `MultiJSON`) and `MultiJSON.dump` (in favor of `generate`), removed in 2.0. Grape detected the backend via `::MultiJson`... Pull #2764 ericproulx github
96.46
27480155161 fix/2763-multijson-deprecations Route Grape::Json through the non-deprecated MultiJSON API multi_json 1.21.0 deprecated the `MultiJson` constant (in favor of `MultiJSON`) and `MultiJSON.dump` (in favor of `generate`), removed in 2.0. Grape detected the backend via `::MultiJson`... Pull #2764 ericproulx github
96.58
27479716970 fix/2763-multijson-deprecations Route Grape::Json through the non-deprecated MultiJSON API multi_json 1.21.0 deprecated the `MultiJson` constant (in favor of `MultiJSON`) and the `MultiJSON.dump`/`MultiJSON.load` method names (in favor of `generate`/`parse`), all removed in 2.0... Pull #2764 ericproulx github
96.56
27479679455 fix/2763-multijson-deprecations Route Grape::Json through the non-deprecated MultiJSON API multi_json 1.21.0 deprecated the `MultiJson` constant (in favor of `MultiJSON`) and the `MultiJSON.dump`/`MultiJSON.load` method names (in favor of `generate`/`parse`), all removed in 2.0... Pull #2764 ericproulx github
96.56
See All Builds (3142)