ruby-grape / grape
97%
master: 97%

LAST BUILD BRANCH: refactor/params-dsl-using-except-kwargs
DEFAULT BRANCH: master
Repo Added
Files 164
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH chore/readability-guard-clauses
branch: chore/readability-guard-clauses
CHANGE BRANCH
x

coverage: 97.004% (+0.03%) from 96.977%
26340504005

Pull #2741

github

ericproulx 
Readability pass: guard clauses, small refactors across lib/

Mostly cosmetic, no behavior change except where noted.

Guard-clause lifts (lift the short-circuit above the if/elsif/else,
let the main flow sit at top indentation):

- `Grape::DSL::Logger#logger`, `DSL::InsideRoute#stream`/`#return_no_content`
- `Grape::Formatter::SerializableHash#serialize`
- `Grape::Middleware::Base#merge_default_options`
- `Grape::Middleware::Error#redispatch`
- `Grape::Middleware::Formatter` (`call!`, `negotiate_content_type`)
- `Grape::Router::Pattern#build_path_from_pattern`
- `Grape::ServeStream::SendfileResponse#respond_to?`
- `Grape::Validations::ParamsScope#configure_declared_params`
- `Grape::Exceptions::ErrorResponse.coerce` (case/when reformatted)

Small extractions:

- `DSL::Entity#entity_class_for_obj`: extract `object_class(object)`
  private helper.
- `DSL::InsideRoute#status`: collapse Symbol/Integer branches and
  extract `default_status` private helper. Error message for an
  unknown status symbol now bubbles up `Rack::Utils.status_code`'s
  own message ("Unrecognized status code :foo_bar") instead of
  Grape's pre-validation message ("Status code :foo_bar is invalid.");
  spec updated.
- `DSL::InsideRoute#stream`: extract `stream_body(value)` private
  helper.
- `DSL::InsideRoute#return_no_content`: drop the redundant `status 204`
  call — `body false` already sets it via the `body` setter.

Minor: `return nil unless` → `return unless` in `Grape::API::Boolean.build`
and `PrimitiveCoercer#call`.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Pull Request #2741: Readability pass: guard clauses + small refactors across lib/

1082 of 1167 branches covered (92.72%)

Branch coverage included in aggregate %.

48 of 52 new or added lines in 14 files covered. (92.31%)

3516 of 3573 relevant lines covered (98.4%)

31695.45 hits per line

Relevant lines Covered
3573 RELEVANT LINES 3516 COVERED LINES
31695.45 HITS PER LINE
Source Files on chore/readability-guard-clauses

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
26340504005 chore/readability-guard-clauses Readability pass: guard clauses, small refactors across lib/ Mostly cosmetic, no behavior change except where noted. Guard-clause lifts (lift the short-circuit above the if/elsif/else, let the main flow sit at top indentation): - `Grape::DSL::L... Pull #2741 ericproulx github
97.0
See All Builds (3031)