rieske / trans
94%
master: 94%

LAST BUILD BRANCH: cleanup/phase-2-deletions
DEFAULT BRANCH: master
Repo Added
Files 272
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH refactor/one-record-per-open-function
branch: refactor/one-record-per-open-function
CHANGE BRANCH
x

coverage: 94.419% (+0.002%) from 94.417%
34124257751

Pull #299

github

rieske 
refactor: one record for the open function scope

SymbolTable kept two members encoding the same fact: functionScopes, a
vector that could never exceed size 1 because C has no nested function
definitions, and scopeIdStack, the block nesting inside it.
isAtFileScope() was defined on the second while guarding reads of the
first, so when enterBlockScope() pushed a scope id with no function
scope open the predicate claimed a function was open and
functionScopes.back() ran on an empty vector.

That state has been patched twice already, once by moving the
predicate onto the stack it guards and once by rejecting the construct
that produced it. Collapsing the two members into a single
optional<FunctionScope> removes the disagreement instead: there is one
place recording whether a function is open, so no future change can
update one and leave the other stale.

Every access goes through openFunction(), which throws rather than
reading an empty container. That covers five public entry points -
enterBlockScope, exitBlockScope, endFunction, getCurrentScopeSymbols
and getCurrentScopeArguments - which were undefined behaviour on an
empty vector before and were guarded by nothing.

nextScopeId stays outside the optional: block ids must not repeat
across functions, since frame-local object names embed them.

The unit test that pinned the old workaround is replaced by one
asserting the state is now refused, and a characterization test covers
the cross-function id invariant that the collapse must not break.
Pull Request #299: refactor: one record for the open function scope

15581 of 16502 relevant lines covered (94.42%)

155803.6 hits per line

Relevant lines Covered
16502 RELEVANT LINES 15581 COVERED LINES
155803.6 HITS PER LINE
Source Files on refactor/one-record-per-open-function

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
34124257751 refactor/one-record-per-open-function refactor: one record for the open function scope SymbolTable kept two members encoding the same fact: functionScopes, a vector that could never exceed size 1 because C has no nested function definitions, and scopeIdStack, the block nesting inside... Pull #299 rieske github
94.42
See All Builds (1238)