rentpath / react-ui
56%
master: 87%

Repo Added 10 Jan 2018 04:07PM UTC

Build # 2356

Committed by

Commit Message

fix(photo): ssr missing img tag

affects: @rentpath/react-ui-core

Issue: We render the \`<img/>\` tag with SSR before. Bbut what happens is the DOM img is loaded in
concurrently while the client bundle is loaded in. So trying to use \`onError\` which react intercepts
ends up in a race condition where the img throws an error in the dom first potentially.
Fix:
Offload setting of src to the handler. Check for differences in src !== fallbackUrl and make
adjustments accordingly. State has to be fired if these 2 are the same so the mounted component will
update and force a re-render.

581 of 1077 branches covered (53.95%)

Branch coverage included in aggregate %.

9 of 9 new or added lines in 1 file covered. (100.0%)

978 of 1708 relevant lines covered (57.26%)

21.67 hits per line

1708 RELEVANT LINES 978 COVERED LINES

21.67 HITS PER LINE

Detailed source file information is not available for this build.

Builds	Branch	Commit	Type	Ran	Committer	Via	Coverage
2356	tj/photo-ssr	fix(photo): ssr missing img tag affects: @rentpath/react-ui-core Issue: We render the \`<img/>\` tag with SSR before. Bbut what happens is the DOM img is loaded in concurrently while the client bundle is loaded in. So trying to use \`onError\` w...	Pull #415	23 Oct 2018 11:45PM UTC	web-flow	travis-ci	pending completion
2355	tj/photo-ssr	fix(photo): ssr missing img tag affects: @rentpath/react-ui-core Issue: We render the \`<img/>\` tag with SSR before. Bbut what happens is the DOM img is loaded in concurrently while the client bundle is loaded in. So trying to use \`onError\` w...	push	23 Oct 2018 11:45PM UTC	tadjohnston	travis-ci	pending completion
2353	tj/photo-ssr	cleanup code	push	23 Oct 2018 07:55PM UTC	tadjohnston	travis-ci	pending completion
2354	tj/photo-ssr	cleanup code	Pull #415	23 Oct 2018 07:54PM UTC	web-flow	travis-ci	pending completion
2352	tj/photo-ssr	fix(photo): ssr missing img tag affects: @rentpath/react-ui-core Issue: We render the \`<img/>\` tag with SSR before. Bbut what happens is the DOM img is loaded in concurrently while the client bundle is loaded in. So trying to use \`onError\` w...	Pull #415	23 Oct 2018 07:25PM UTC	web-flow	travis-ci	pending completion
2351	tj/photo-ssr	fix(photo): ssr missing img tag affects: @rentpath/react-ui-core Issue: We render the \`<img/>\` tag with SSR before. Bbut what happens is the DOM img is loaded in concurrently while the client bundle is loaded in. So trying to use \`onError\` w...	push	23 Oct 2018 07:24PM UTC	tadjohnston	travis-ci	pending completion
2350	tj/photo-ssr	fix(photo): ssr missing img tag affects: @rentpath/react-ui-core Issue: We render the \`<img/>\` tag with SSR before. Bbut what happens is the DOM img is loaded in concurrently while the client bundle is loaded in. So trying to use \`onError\` w...	Pull #415	23 Oct 2018 07:13PM UTC	web-flow	travis-ci	pending completion
2349	tj/photo-ssr	fix(photo): ssr missing img tag affects: @rentpath/react-ui-core Issue: We render the \`<img/>\` tag with SSR before. Bbut what happens is the DOM img is loaded in concurrently while the client bundle is loaded in. So trying to use \`onError\` w...	push	23 Oct 2018 07:13PM UTC	tadjohnston	travis-ci	pending completion

rentpath / react-ui
56%
master: 87%

rentpath / react-ui 56% master: 87%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

CHANGE BRANCH x

Relevant lines Covered

Source Files on tj/photo-ssr

Recent builds

rentpath / react-ui
56%
master: 87%

README BADGES
x

CHANGE BRANCH
x