recurly / recurly-js

92%

master: 91%

LAST BUILD ON BRANCH paypal-cancel-fix

branch: paypal-cancel-fix

CHANGE BRANCH

x

Reset

• paypal-cancel-fix
• 2.4.1
• 3d-secure-wirecard
• 3ds-require-action-token
• 3ds-set-container-dimenstions
• 3ds-window-sizing
• 3ds-worldpay
• 3ds2
• 3ds2-fix-braintree-authentication-amount
• 3ds2-wirecard-challenge-iframe
• 4.15.1
• 4.16.0
• 4.16.1
• 4.16.2
• EE-697
• FK-707
• SWI-1524
• aaron-suarez/remove-lodash-isFinite
• ac/pay-6030
• add-currency-to-preflight
• add-eslint
• add-eu-api-endpoint
• add-field-tokenization-validation-tests
• add-fraud-params-to-apple-pay-token
• add-gateway-code-to-risk-preflight
• add_auto-tabbing_to_combined_card_field
• add_bacs_support
• add_becs_support
• add_gateway_code_paypal_complete
• add_gateway_code_paypal_complete_2
• add_iframe_titles
• add_iframe_titles_opt2
• adds-union-pay
• adyen-components
• adyen-hpp-tests
• adyen-paymennt-endpoints
• adyen_3ds
• adyen_3ds_event_name
• apple-pay
• apple-pay-billing-contact
• apple-pay-callback
• apple-pay-custom-line-items
• apple-pay-errors
• apple-pay-info-currency
• apple-pay-passthrough
• apple-pay-price-tax
• apple-pay-pricing-init
• apple-pay-pricing-promise
• apple-pay-recurring
• apple-pay-v4
• applepay-tokenize-tax-fields
• auto-version
• bank-account-types
• baw/update-elo-card-length
• bk-discover-bins
• bk/elo-bins
• boleto-list-payment-methods
• braintree_proactive_3ds
• browserstack
• browserstack-up
• bump-mobile
• bus-groups
• cache-plans
• cartes-bancaires
• cartes-bancaires-with-adyen-test-card-number
• cb/3ds-sagepay
• cb/braintree_3ds
• cb/pay-5705
• chase-3ds
• checkout-pricing-items
• ci-ios-13
• ci-lint
• ci-update
• cleanup
• cnpj-tax-id
• co-brands-options
• co-brands-support
• cobranding
• coverage
• credit-card-types-refactor
• cybersource-3ds2
• dependabot/npm_and_yarn/acorn-6.4.1
• dependabot/npm_and_yarn/bl-4.0.3
• dependabot/npm_and_yarn/decode-uri-component-0.2.2
• dependabot/npm_and_yarn/electron-10.1.2
• dependabot/npm_and_yarn/electron-10.2.0
• dependabot/npm_and_yarn/electron-11.5.0
• dependabot/npm_and_yarn/electron-13.6.6
• dependabot/npm_and_yarn/electron-15.5.5
• dependabot/npm_and_yarn/electron-18.3.7
• dependabot/npm_and_yarn/elliptic-6.5.3
• dependabot/npm_and_yarn/engine.io-3.6.0
• dependabot/npm_and_yarn/engine.io-and-socket.io-3.6.0
• dependabot/npm_and_yarn/engine.io-and-socket.io-3.6.1
• dependabot/npm_and_yarn/eventsource-1.1.1
• dependabot/npm_and_yarn/eventsource-1.1.2
• dependabot/npm_and_yarn/ini-1.3.7
• dependabot/npm_and_yarn/loader-utils-1.4.2
• dependabot/npm_and_yarn/lodash-4.17.19
• dependabot/npm_and_yarn/moment-2.29.4
• dependabot/npm_and_yarn/simple-get-3.1.1
• dependabot/npm_and_yarn/socket.io-2.4.1
• dependabot/npm_and_yarn/socket.io-parser-3.3.3
• dependabot/npm_and_yarn/terser-4.8.1
• dependabot/npm_and_yarn/url-parse-1.5.10
• dependabot/npm_and_yarn/url-parse-1.5.7
• dependabot/npm_and_yarn/websocket-extensions-0.1.4
• dependabot/npm_and_yarn/xmldom/xmldom-and-xmldom/xmldom-0.8.3
• dependabot/npm_and_yarn/xmldom/xmldom-and-xmldom/xmldom-0.8.5
• dev-corp
• devserver
• discount-rounding
• docker
• drop-ie-11
• dt-changes
• dt-ci
• e2e
• e2e-automation
• e2e-field-state
• e2e-fraud
• e2e-required-cvv
• e2e-struct
• edge-ci
• ee2237_worldpay_3ds_prod_fix
• ee2237_worldpay_3ds_prod_fix_testing
• electron
• electron-e2e
• elements
• elements-focus-type
• emit-fraud-error
• emit_ready_event
• empty-plan-error-message
• enable-cup-for-stripe
• error-reporting
• eslint-quotes
• events
• events-batching
• events-errors
• events-fields
• events-meta
• events-pricing
• events-ready
• exclude-react-recurly-on-pr
• export-test-server
• failfast
• fix-addon-calculations
• fix-addon-removal
• fix-apple-ay-shipping-method-parse
• fix-billing-info-test
• fix-braintree-applepay-cancel
• fix-ci-bstack-connection
• fix-ci-react-recurly
• fix-ci-shims
• fix-coupon-plan-resolution
• fix-dep
• fix-dt-checkout-action
• fix-dt-gha-trigger
• fix-dtslint-config
• fix-empty-configure-error
• fix-failing-e2e-tests
• fix-field-format-propagation
• fix-hosted-field-reset-on-configure
• fix-httplib2-build
• fix-prev-tab
• fix-promise-reference
• fix-snapshots
• fix-storage-availability
• fix-storage-availability-chrome
• fix-subscription-single-use-discount
• fix-tabbing-mobile
• fix-tabbing-specs
• fix-tax-min
• fix-test-unit-debug
• fix-tests
• fix-tiered-pricing
• fix-tiered-unit-price-labels
• fix-types
• fix-wds-opts
• fix-worker-error
• fk-1314
• font-load-e2e
• frame-enum
• fraud-endpoint
• fraud-for-card-field
• gcs-artifacts
• github-codeowners
• google-pay
• google-pay-email
• handle-stripe-elements-errors
• hidden-input-accessibility
• hpp-brand-picker
• iban
• ideal
• ideal-camelize
• ideal-require-invoice_uuid
• implementer-specified-device-data-collection
• issue-templates
• jpg/tax-identifiers
• jsanin/test-branch
• jsonp-tests
• kount-udf
• linux-build
• loosen-e2e-diff-threshold
• master
• master-rebuild-v3
• mergesynctest
• more-coverage
• multi-form-fraud-detection
• no-lvh
• npm-audit
• ofl-618-cobranding
• osa
• package-up
• packages
• paypal-cancel-event
• paypal-complete-paypal-method
• paypal-destroy-db
• paypal-on-commerce
• paypal-token-type-fix
• paypal-types
• paypalcommerce-3ds-spike
• pricing-contacts
• pricing-custom-tax-amount
• pricing-set-on-cancel
• qa2
• ready-ts
• rebuild-master
• rebuild-master-v2
• recurring-payment-request
• release-notes
• release-scripts
• release-types
• remove-after
• remove-phantom
• replace-denodeify
• report-field-type
• report-period
• revert-685-github-codeowners
• revert-752-cartes-bancaires
• revert-cup
• rjs-brand-picker
• round_tax_amount
• sagepay-3ds2
• sauce
• sauce-extended-debugging
• sauce-improvements
• select_paypal_gateway
• sequential_preflights
• set-type-hidden-on-fraud-detection-input
• sofort
• splitting-ie-tests
• stripe-pi-id
• support_setup_intents_on_3ds2
• supported-methods-override
• tarjeta-naranja-bins
• test-4.13.1
• test-ci
• test-karma-ios-launcher-upgrade
• test-react-recurly
• tests
• travis-stability
• ts-add-google-pay
• ts-doc
• ts-updates
• types-update
• typescript
• typescript-docs
• typescript-exports
• uniq
• unit-bstack-tunnel
• unit-ci-electron
• unit-split-ie
• update-adyen-ideal-sdk-version
• update-braintree-3ds
• update-bt
• update-ci
• update-ci-platforms
• update-dependencies
• update-deps
• update-dt-workflow
• update-keys
• update-packages
• upgrade-deps
• use-inclusive-terms
• use-terser
• uuids
• v4.10.0
• v4.10.0-beta
• v4.10.1
• v4.10.2
• v4.10.3
• v4.11.0
• v4.12.0
• v4.13.0
• v4.13.1
• v4.14.0
• v4.15.0
• v4.15.1
• v4.15.1-temp
• v4.16.0
• v4.16.1
• v4.16.2
• v4.17.0
• v4.17.1
• v4.18.0
• v4.18.1
• v4.19.0
• v4.19.1
• v4.20.0
• v4.20.1
• v4.20.2
• v4.21.0
• v4.21.1
• v4.22.0
• v4.22.1
• v4.22.2
• v4.22.3
• v4.22.4
• v4.22.5
• v4.22.6
• v4.22.7
• v4.22.8
• v4.22.9
• v4.23.0
• v4.23.1
• v4.8.6
• v4.8.7
• v4.9.0
• v4.9.1
• v4.9.2
• v4.9.3
• v4.9.4
• v4.9.5
• v4.9.6
• v4.9.7
• v5.0.0
• validation-error-details
• venmo
• venmo-desktop
• win-11
• worldpay_3ds_prod_fix
• worldpay_3ds_prod_fix_testing

Build # 2800

Build Type

Pull #564

travis-ci

Committed by web-flow

Commit Message

Fixes Frame close race condition

When a Frame is created as a popover window, a window close listener
is created to observe when the window has been closed. This runs on a 1s
interval.

If a Frame subsequently finishes its task and sends its completion event,
that close listener was not properly disposed of. The resulting
behavior was a race condition where the close listener may announce
the window closure after the Frame had completed its task.

This ensures the close listener is cleared, and ends the race behavior
when the Frame is done.

Pull Request Pull Request #564: Fixes an issue with paypal incorrectly emitting a cancel event on success

Run Details

1010 of 1266 branches covered (79.78%)

12 of 12 new or added lines in 1 file covered. (100.0%)

2217 of 2399 relevant lines covered (92.41%)

11552.91 hits per line