recurly / recurly-js / 2800

92%

master: 91%

Pull #564

travis-ci

Fixes Frame close race condition

When a Frame is created as a popover window, a window close listener
is created to observe when the window has been closed. This runs on a 1s
interval.

If a Frame subsequently finishes its task and sends its completion event,
that close listener was not properly disposed of. The resulting
behavior was a race condition where the close listener may announce
the window closure after the Frame had completed its task.

This ensures the close listener is cleared, and ends the race behavior
when the Frame is done.

1010 of 1266 branches covered (79.78%)

12 of 12 new or added lines in 1 file covered. (100.0%)

2217 of 2399 relevant lines covered (92.41%)

11552.91 hits per line