• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

puppetlabs / facter
87%
master: 87%

Build:
Build:
LAST BUILD BRANCH: 3.12.x
DEFAULT BRANCH: master
Repo Added 04 Nov 2015 05:20PM UTC
Files 7
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH 3.11.x
branch: 3.11.x
CHANGE BRANCH
x
Reset
  • 3.11.x
  • 3.6.x

pending completion
4525

Pull #1753

travis-ci

Enis Inan
(FACT-1873) Use builtin fact if custom facts don't resolve or have 0 wt.

Previously, if any builtin facts have conflicting custom facts that all
fail to resolve, and at least one of the custom facts has a weight > 0,
Facter will not report a value for that fact. This is undesirable
behavior because we always want to fall back to the builtin value if
all custom facts fail to resolve. Note that the "weight > 0" part is
important because Facter _will_ use the builtin value if all custom
facts have 0 weight.

Furthermore, the builtin fact should have precedence over 0 weight
custom facts. The existing code enforces this condition when _all_
custom facts have 0 weight, but it does _not_ enforce the condition
when only _some_ custom facts have 0 weight. In the latter case, the 0
weight custom facts will take precedence over the builtin fact value.

This commit fixes the fact resolution logic so that it falls back to the
built-in fact if all custom facts fail to resolve, while also ensuring
that it has precedence over 0 weight custom facts.
Pull Request #1753:

9796 of 11229 relevant lines covered (87.24%)

90.61 hits per line

Relevant lines Covered
Build:
Build:
11229 RELEVANT LINES 9796 COVERED LINES
90.61 HITS PER LINE
Source Files on 3.11.x
Detailed source file information is not available for this build.

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
4525 3.11.x (FACT-1873) Use builtin fact if custom facts don't resolve or have 0 wt. Previously, if any builtin facts have conflicting custom facts that all fail to resolve, and at least one of the custom facts has a weight > 0, Facter will not report a valu... Pull #1753 09 Oct 2018 01:57AM UTC Enis Inan travis-ci pending completion  
4524 3.11.x (FACT-1873) Use builtin fact if custom facts don't resolve or have 0 weight Previously, if any builtin facts have conflicting custom facts that all fail to resolve, and at least one of the custom facts has a weight > 0, Facter will not report a v... Pull #1753 09 Oct 2018 01:55AM UTC Enis Inan travis-ci pending completion  
4523 3.11.x (FACT-1873) Use builtin fact if custom facts don't resolve or have 0 weight Previously, if any builtin facts have conflicting custom facts that all fail to resolve, and at least one of the custom facts has a weight > 0, Facter will not report a v... Pull #1753 09 Oct 2018 01:19AM UTC Enis Inan travis-ci pending completion  
4522 3.11.x (FACT-1873) Use builtin fact if custom facts don't resolve or have 0 weight Previously, if any builtin facts have conflicting custom facts that all fail to resolve, and at least one of the custom facts has a weight > 0, Facter will not report a v... Pull #1753 09 Oct 2018 01:00AM UTC Enis Inan travis-ci pending completion  
4521 3.11.x (FACT-1873) Use builtin fact if custom facts don't resolve or have 0 weight Previously, if any builtin facts have conflicting custom facts that all fail to resolve, and at least one of the custom facts has a weight > 0, Facter will not report a v... Pull #1753 09 Oct 2018 12:58AM UTC Enis Inan travis-ci pending completion  
4520 3.11.x (FACT-1873) Use builtin fact if custom facts don't resolve or have 0 weight Previously, if any builtin facts have conflicting custom facts that all fail to resolve, and at least one of these custom facts has a weight > 0, Facter will not report a... Pull #1753 09 Oct 2018 12:52AM UTC Enis Inan travis-ci pending completion  
4518 3.11.x (FACT-1873) Use builtin fact value if custom facts don't resolve Previously, if any builtin facts have conflicting custom facts that all fail to resolve, and at least one of these custom facts has a weight > 0, Facter will not report a value for ... Pull #1753 07 Oct 2018 11:09AM UTC Enis Inan travis-ci pending completion  
4515 3.11.x (FACT-1872) Add support for dmi.product.uuid for Windows platforms Pull #1752 28 Sep 2018 03:37PM UTC Scott Garman travis-ci pending completion  
4514 3.11.x (FACT-1872) Add support for dmi.product.uuid for Windows platforms Pull #1752 28 Sep 2018 03:02AM UTC Scott Garman travis-ci pending completion  
4501 3.11.x Merge pull request #1748 from ekinanp/os_version_2012 (maint) Fix expected os_version fact to distinguish 2012 and 2012 R2 push 19 Sep 2018 06:55PM UTC GitHub travis-ci pending completion  
See All Builds (1455)
  • Repo on GitHub
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc