4520
87%
master: 87%

Ran 09 Oct 2018 12:52AM UTC

Jobs 1

Files 380

Run time 7min

Badge

Embed ▾

pending completion

Build # 4520

Build Type

Pull #1753

travis-ci

Committed by Enis Inan

Commit Message

(FACT-1873) Use builtin fact if custom facts don't resolve or have 0 weight

Previously, if any builtin facts have conflicting custom facts that all
fail to resolve, and at least one of these custom facts has a weight >
0, Facter will not report a value for that fact. This is undesirable
behavior because we always want to fall back to the builtin value if
all custom facts fail to resolve. Note that the "weight > 0" part is
important because Facter _will_ use the builtin value if all custom
facts have 0 weight.

Furthermore, the builtin fact should have precedence over 0 weight
custom facts. The existing code enforces this condition when _all_
custom facts have 0 weight, but it does _not_ enforce the condition
when only _some_ custom facts have 0 weight. In the latter case, the 0
weight custom facts will take precedence over the builtin fact value.

This commit fixes the fact resolution logic so that it falls back to the
built-in fact if all custom facts fail to resolve, while also ensuring
that it has precedence over 0 weight custom facts.

Pull Request Pull Request #1753:

Run Details

9793 of 11226 relevant lines covered (87.23%)

90.57 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
6	4520.6 (TRAVIS_TARGET=DEBUG)	09 Oct 2018 12:52AM UTC	0	87.23	Travis Job 4520.6

Source Files on build 4520

Detailed source file information is not available for this build.

puppetlabs / facter / 4520
87%
master: 87%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4520

puppetlabs / facter / 4520 87% master: 87%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4520

puppetlabs / facter / 4520
87%
master: 87%

README BADGES
x