• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

pulibrary / allsearch_api
100%
main: 100%

Build:
Build:
LAST BUILD BRANCH: configs-once
DEFAULT BRANCH: main
Repo Added 23 Apr 2025 05:42PM UTC
Files 82
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH remove-library-database-record
branch: remove-library-database-record
CHANGE BRANCH
x
Reset
  • remove-library-database-record
  • 100-percent-coverage
  • 377-multiple-onliine-results
  • activesupport-concern
  • add-rake-to-gemfile
  • blank-1
  • bundle-update-06162025
  • catalog-rack-app
  • config-for
  • config-hosts
  • configs-once
  • coverage
  • database-cleaner
  • database-record-rom
  • delegators
  • dependabot/bundler/activerecord-8.0.2.1
  • dependabot/bundler/nokogiri-1.18.9
  • dependabot/bundler/rack-3.1.14
  • dependabot/bundler/rack-3.1.16
  • dependabot/bundler/rack-3.1.17
  • dependabot/bundler/rack-3.1.18
  • dependabot/bundler/rack-session-2.1.1
  • dependabot/bundler/rexml-3.4.2
  • dependabot/bundler/thor-1.4.0
  • dpul-rack
  • engineering_search_spike
  • file-fixture
  • flipper-add
  • flipper-again
  • flipper-sequel
  • flipper-sequel-problem
  • fqdn_deploy_files
  • healthcheck
  • i360_staff_name_link
  • i371_engineering_librarian_bug
  • main
  • migrate-some-more-rails-controllers
  • missing-gem
  • no-parallelism
  • oauth-token
  • path-file-instead-of-rails-root
  • present-2
  • pry-byebug
  • query-in-rom
  • rack-router
  • rake-console
  • remove-action-view
  • remove-activemodel-api
  • remove-psb-flipper
  • remove-remaining-banner
  • remove-rspec-rails
  • remove-rubocop-rspec-rails
  • remove-status-uris
  • remove-time-helpers
  • replace-all-controllers
  • replace-present-1
  • replace-rswag
  • repo-factory
  • rom-rb-2
  • rom-repo
  • rubocop
  • rubocop-plugins
  • sandbergja-patch-1
  • self_hosted_runner_experiment
  • semantic_logger
  • serve-openapi-spec-with-rack
  • serve-swagger-with-rack
  • solr9-lando-catalog
  • spec-helper-instead-of-rails-helper
  • starting-fresh
  • tests-rom
  • truncate
  • unneeded-requires
  • update-openapi-spec

02 Dec 2025 04:55PM UTC coverage: 99.904% (+0.001%) from 99.903%
55f37a69-f198-45d6-96dc-4272aa3cb82c

Pull #415

circleci

sandbergja
Remove ActiveRecord-based LibraryDatabaseRecord class

This also improves the performance of loading Library Database metadata from Lib-jobs
by combining all creation into a single INSERT query, rather than running an INSERT
for each row in the CSV.

To confirm, I ran this benchmark before deleting the LibraryDatabaseRecord class:

```
Benchmark.ips do |b|
  library_database_repo = LibraryDatabaseRepository.new Rails.application.config.rom
  csv = CSV.read Rails.root.join('spec/fixtures/files/libjobs/library-databases.csv'), headers: true
  b.report('LibraryDatabaseRecord::new_from_csv') do
    csv.each { LibraryDatabaseRecord.new_from_csv(it)}
    library_database_repo.delete
  end

  b.report('LibraryDatabaseRepository#create_from_csv') do
    library_database_repo.create_from_csv csv
    library_database_repo.delete
  end

  b.compare!
end
```

Results:

```
Warming up --------------------------------------
LibraryDatabaseRecord::new_from_csv
                         3.000 i/100ms
LibraryDatabaseRepository#create_from_csv
                        10.000 i/100ms
Calculating -------------------------------------
LibraryDatabaseRecord::new_from_csv
                         28.764 (±27.8%) i/s   (34.77 ms/i) -    135.000 in   5.004122s
LibraryDatabaseRepository#create_from_csv
                        116.179 (±18.9%) i/s    (8.61 ms/i) -    560.000 in   5.031764s

Comparison:
LibraryDatabaseRepository#create_from_csv:      116.2 i/s
LibraryDatabaseRecord::new_from_csv:       28.8 i/s - 4.04x  slower
```

Closes #402
Pull Request #415: Remove ActiveRecord-based LibraryDatabaseRecord class

14 of 14 new or added lines in 2 files covered. (100.0%)

20 existing lines in 4 files now uncovered.

1040 of 1041 relevant lines covered (99.9%)

104.28 hits per line

Relevant lines Covered
Build:
Build:
1041 RELEVANT LINES 1040 COVERED LINES
104.28 HITS PER LINE
Source Files on remove-library-database-record
  • Tree
  • List 70
  • Changed 2
  • Source Changed 2
  • Coverage Changed 2
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
55f37a69... remove-library-database-record Remove ActiveRecord-based LibraryDatabaseRecord class This also improves the performance of loading Library Database metadata from Lib-jobs by combining all creation into a single INSERT query, rather than running an INSERT for each row in the CS... Pull #415 02 Dec 2025 04:57PM UTC sandbergja circleci
99.9
968494f1... remove-library-database-record Remove ActiveRecord-based LibraryDatabaseRecord class This also improves the performance of loading Library Database metadata from Lib-jobs by combining all creation into a single INSERT query, rather than running an INSERT for each row in the CS... push 02 Dec 2025 04:54PM UTC sandbergja circleci
99.9
839bcb31... remove-library-database-record Remove ActiveRecord-based LibraryDatabaseRecord class Closes #402 push 02 Dec 2025 04:36PM UTC sandbergja circleci
99.9
See All Builds (197)
  • Repo on GitHub
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc