pulibrary / allsearch_api

99%

main: 100%

LAST BUILD ON BRANCH 452-use-rom-when-possible

branch: 452-use-rom-when-possible

CHANGE BRANCH

x

Reset

• 452-use-rom-when-possible
• 100-percent-coverage
• 377-multiple-onliine-results
• 400-migrate-best-bet-to-rom
• 401-migrate-library-staff-to-rom-db
• 403-database-rom
• 404-connect-without-activerecord
• 457-brakeman-remove
• 459-rails-rubocop
• 486-remove-index_with
• 487-rack-datadog-instrumentation
• 514-remmove-railties-railsCommands
• 514-remove-railties
• 514-remove-railties-applicationRb
• 514-remove-railties-capistrano
• 514-remove-railties-comment-update
• 514-remove-railties-honeybadger
• 514-strat-removing-railties
• 525-replace-rails-env-with-app-env
• 539-swagger-security-policy
• activesupport-concern
• activesupport-remove
• add-rake-to-gemfile
• ampersands
• array-exclude
• banner-rake-tasks
• blank-1
• bundle-update-06162025
• bundle-update-2025-12-22
• catalog-rack-app
• config-for
• config-hosts
• configs-once
• constantize
• coverage
• csp-middleware
• database-cleaner
• database-record-rom
• datadog-cleanup
• delegators
• delete-middlewares
• dependabot/bundler/activerecord-8.0.2.1
• dependabot/bundler/bootsnap-1.20.1
• dependabot/bundler/bootsnap-1.21.1
• dependabot/bundler/byebug-13.0.0
• dependabot/bundler/datadog-2.24.0
• dependabot/bundler/datadog-2.26.0
• dependabot/bundler/nokogiri-1.18.9
• dependabot/bundler/pg-1.6.3
• dependabot/bundler/rack-3.1.14
• dependabot/bundler/rack-3.1.16
• dependabot/bundler/rack-3.1.17
• dependabot/bundler/rack-3.1.18
• dependabot/bundler/rack-session-2.1.1
• dependabot/bundler/rexml-3.4.2
• dependabot/bundler/rubocop-rspec-3.9.0
• dependabot/bundler/thor-1.4.0
• dependabot/bundler/thor-1.5.0
• dependabot/bundler/tzinfo-data-1.2025.3
• dependabot/bundler/whenever-1.1.2
• dpul-rack
• engineering_search_spike
• faster-sanitize
• file-fixture
• fix-main
• fix-run-rspec
• flipper-add
• flipper-again
• flipper-sequel
• flipper-sequel-problem
• fqdn_deploy_files
• gemfile
• get-local-puma-running-again
• healthcheck
• host-header-protections
• i360_staff_name_link
• i371_engineering_librarian_bug
• initialize-9
• initializers
• initializers-2
• initializers-4
• initializers-6
• initializers-7
• load-landoenv
• log-level-info
• log-the-path
• logger
• logger-test-coverage
• main
• middleware
• migrate-some-more-rails-controllers
• missing-gem
• more-link-staff
• move-environment-to-init
• move-some-middlewares
• no-environment-for-solr
• no-environment-for-summon-tester
• no-more-rails-middleware
• no-parallelism
• oauth-token
• path-file-instead-of-rails-root
• presence
• present-2
• pry-byebug
• puma-config
• query-in-rom
• rack-cors-in-config-ru
• rack-router
• rails-groups
• rails-root-join
• rake-c-db-2
• rake-console
• rake-servers-start
• remove-action-view
• remove-actionpack
• remove-activemodel-api
• remove-activerecord-activemodel
• remove-be-present
• remove-blank
• remove-environment-from-openapi
• remove-environment-from-rake-task
• remove-library-database-record
• remove-psb-flipper
• remove-remaining-banner
• remove-rspec-rails
• remove-rubocop-rspec-rails
• remove-second
• remove-some-requires
• remove-status-uris
• remove-time-helpers
• remove-to-query
• remove_cap_rails
• remove_rails_references
• reopen-semantic-logger-after-passenger-fork
• replace-all-controllers
• replace-present-1
• replace-rswag
• repo-factory
• rom-rb-2
• rom-repo
• rubocop
• rubocop-plugins
• rubocop-tmp
• sandbergja-patch-1
• sanitizer
• self_hosted_runner_experiment
• semantic_logger
• serve-openapi-spec-with-rack
• serve-swagger-with-rack
• simplifiy-mapping
• solr9-lando-catalog
• spec-helper
• spec-helper-instead-of-rails-helper
• starting-fresh
• static-file
• summon-multiple-requests
• test-rom
• tests
• tests-rom
• time-zone
• to-sentence
• truncate
• tzinfo
• unneeded-requires
• update-deployrb-related-to-514
• update-openapi-spec
• use-our-own-autoloader
• use-our-routes
• use-ruby-json

Build # 8c960e6c-1dd5-469c-81dd-d7ce91d2146b

Build Type

Pull #471

circleci

Committed by christinach

Commit Message

-self.call always passes both arguments -> make env a required parameter and remove the conditional
when initializing rackResponseController
- Update RackResponseController and pass rom only when services need it

related to [#452]

Pull Request Pull Request #471: Use env rom instead of Rails.application.config.rom when possible

Run Details

34 of 34 new or added lines in 18 files covered. (100.0%)

1353 of 1360 relevant lines covered (99.49%)

77.32 hits per line