psss / did

68%

master: 79%

LAST BUILD ON BRANCH fix.log_load

branch: fix.log_load

CHANGE BRANCH

x

Reset

• fix.log_load
• 0.10
• 0.11
• 0.12
• 0.13
• 0.14
• 0.16
• 0.5
• 0.6
• 0.7
• 0.8
• 0.9
• devel
• feat.argparse.clean
• feat.argparse.cleaner
• feat.invoke.bob
• master
• packit
• python2
• python3
• weird
• working

Build # 283

Build Type

push

travis-ci

Committed by kejbaly2

Commit Message

don't create new Logging instance uncessarily

Minor thing; why call utils.Logging("did") instead of just caching that logger into the namespace and calling the (more) locally scoped variable?
cli.py

lines
    20 from did.utils import log
...
```
 39         # Enable debugging output (even before options are parsed)
 40         if "--debug" in sys.argv:
 41             utils.Logging("did").set(utils.LOG_DEBUG)
```

did.utils.log is utils.Logging("did").logger

What about

```
 39         # Enable debugging output (even before options are parsed)
 40         if "--debug" in sys.argv:
 41             utils.Logging("did").set(utils.LOG_DEBUG)
```

Run Details

1058 of 1557 relevant lines covered (67.95%)

1.36 hits per line