• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

psss / did / 283
68%
master: 79%

Build:
Build:
LAST BUILD BRANCH: fix-up-jira
DEFAULT BRANCH: master
Ran 28 Sep 2015 08:04PM UTC
Jobs 2
Files 18
Run time 5s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
283

push

travis-ci

kejbaly2
don't create new Logging instance uncessarily

Minor thing; why call utils.Logging("did") instead of just caching that logger into the namespace and calling the (more) locally scoped variable?
cli.py

lines
    20 from did.utils import log
...
```
 39         # Enable debugging output (even before options are parsed)
 40         if "--debug" in sys.argv:
 41             utils.Logging("did").set(utils.LOG_DEBUG)
```

did.utils.log is utils.Logging("did").logger

What about

```
 39         # Enable debugging output (even before options are parsed)
 40         if "--debug" in sys.argv:
 41             utils.Logging("did").set(utils.LOG_DEBUG)
```

1058 of 1557 relevant lines covered (67.95%)

1.36 hits per line

Jobs
ID Job ID Ran Files Coverage
1 283.1 28 Sep 2015 08:04PM UTC 0
67.95
Travis Job 283.1
2 283.2 28 Sep 2015 08:04PM UTC 0
67.89
Travis Job 283.2
Source Files on build 283
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #283
  • 56161e7f on github
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc