prometheus / client_ruby

100%

master: 100%

LAST BUILD ON BRANCH dont_revalidate_symbols_on_increment

branch: dont_revalidate_symbols_on_increment

CHANGE BRANCH

x

Reset

• dont_revalidate_symbols_on_increment
• RichiH-patch-1
• add_script_name_in_collector_path
• all_metrics_one_file
• beorn7/doc
• beorn7/license-cleanup
• beorn7/meta
• beorn7/push
• bump_version_0_11_alpha
• coveralls
• document_startup_file_cleanup
• exchangeable-value-types
• fix_all_labels_preset_warning
• fix_jruby_travis
• fix_label_order_bug
• fix_with_labels
• grobie/add-path-substitution-example
• grobie/basic-auth
• grobie/ensure-non-nil-values
• grobie/fix-gauge-increment-documentation
• grobie/fix-histogram-bucket-metrics
• grobie/fix-lint-warnings
• grobie/fix-rubocop
• grobie/fix-travis-build-old-ruby
• grobie/middleware-rewrite
• grobie/sanitize-http-path-by-default
• grobie/validate-metric-name
• gzip
• improved_documentation
• init_metrics_without_labels
• labelset_validator_cache_mutex
• labelset_validator_no_cache
• labelset_validator_nocache_norevalidatesymbols
• master
• multiprocess
• push
• refactor
• remove-counter-decrement
• remove-json-format
• remove_deprecated_escaping
• repo_sync
• sinjo-add-missing-require
• sinjo-bump-version
• sinjo-consistent-metric-stores
• sinjo-default-unaggregated-gauges
• sinjo-improve-path-handling
• sinjo-label-values-to-s
• sinjo-per-store-docs
• sinjo-readme-tweaks
• sinjo-remove-flexible-rack-labels
• sinjo-remove-old-version-pins
• sinjo-reopen-on-fork
• sinjo-unaggregated-gauges
• sinjo-update-gemspec
• sinjo-update-gemspec-authors
• sinjo-update-maintainers
• sinjo-wordsmithing
• support_latest_rubies
• support_ruby_3
• textformat
• travis-2.2.x
• turn_on_rspec_warnings
• update-example
• use_monitor_instead_of_read_write_lock
• v0.10.0
• v0.10.0.pre.alpha.1
• v0.10.0.pre.alpha.2
• v0.11.0.pre.alpha.1
• v0.3.0
• v0.3.0.pre.rc.1
• v0.3.1
• v0.4.0
• v0.4.1
• v0.4.2
• v0.5.0
• v0.6.0
• v0.7.0
• v0.7.0.pre.rc.1
• v0.7.1
• v0.8.0
• v0.9.0
• v1.0.0
• v1_0
• v2.0.0
• v2.1.0
• v2_0
• v2_1

Build # 445

Build Type

Pull #144

travis-ci

Committed by web-flow

Commit Message

Avoid revalidating labelset keys on each metric observation

When declaring a metric, we declare what label keys will be used for it.
At that point, we validate that those are all valid keys (symbols,
match a given regex, etc).

Then, on each observation of the metric, we validate that the keys passed
in for the labels match the ones we were originally expecting, to make
sure all of those labels were set, but no others.

We were also, at that point, validating that the keys passed in are valid.
This validation is pretty slow, and it's redundant, since keys that aren't
valid won't match the expected ones anyway, so we can just compare just
that those match. This has quite a pronounced effect on performance.

Pull Request Pull Request #144: Avoid revalidating labelset keys on each metric observation

Run Details

8 of 8 new or added lines in 2 files covered. (100.0%)

1417 of 1417 relevant lines covered (100.0%)

14.53 hits per line