prometheus / client_ruby
84%
master: 100%

LAST BUILD BRANCH: fix_with_labels
DEFAULT BRANCH: master
Repo Added
Files 32
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH all_metrics_one_file
branch: all_metrics_one_file
CHANGE BRANCH
x

519

Pull #161

travis-ci

web-flow 
Fix the "subtle" bug introduced in the previous commit

So, again, I don't propose we actually do this, this is just illustrative
of what we need to do, and didn't want it to get lost.

The problem with the previous commit is that for each metric, we open a
new FileMappedDict. All of them sharing the same file is "fine", actually.
The problem comes from the fact that each instance of FileMappedDict has
their own version of `@used`. When one metric adds a new entry to the file,
it moves its own `@used` pointed, but the other instances don't notice this.

As soon as a second instance that had already been loaded adds a new labelset,
it corrupts the file.

This only shows up when running the benchmarks, with histograms. Counters
(in our benchmark) don't reproduce it, because each metric in our benchmark
only has one labelset. They all get added initially to the file, and an
already loded Dict doesn't add new ones. The reason Histograms reproduce it
is that new observations may report a bucket that wasn't seen before, which
is effectively a new labelset.

The solution is for all MetricStore instances to share one single FileMappedDict.
This is not particularly hard, but the current MetricStore is not written
in a way that allows that without doing this crap.

We should find a better way. I'm just leaving this here as documentation
of this problem, for the next brave soul attempting this
Pull Request #161: One file per process instead of per metric/process for DirectFileStore [DOESNT WORK]

53 of 53 new or added lines in 2 files covered. (100.0%)

3855 of 4587 relevant lines covered (84.04%)

33.18 hits per line

Relevant lines Covered
4587 RELEVANT LINES 3855 COVERED LINES
33.18 HITS PER LINE
Source Files on all_metrics_one_file
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
519 all_metrics_one_file Fix the "subtle" bug introduced in the previous commit So, again, I don't propose we actually do this, this is just illustrative of what we need to do, and didn't want it to get lost. The problem with the previous commit is that for each metric,... Pull #161 web-flow travis-ci pending completion  
518 all_metrics_one_file Fix the "subtle" bug introduced in the previous commit So, again, I don't propose we actually do this, this is just illustrative of what we need to do, and didn't want it to get lost. The problem with the previous commit is that for each metric,... push dmagliola travis-ci pending completion  
See All Builds (639)