• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

projecthydra-labs / hydra-works
99%
master: 99%

Build:
Build:
LAST BUILD BRANCH: v0.11.0
DEFAULT BRANCH: master
Repo Added 12 May 2015 02:24PM UTC
Files 28
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH extracting-collaborating-class
branch: extracting-collaborating-class
CHANGE BRANCH
x
Reset
  • extracting-collaborating-class
  • 0.2.0
  • 107-bug_with_load_instance_from_solr
  • 53-update_readme
  • add_dependencies
  • add_file_more_kargs
  • add_file_service
  • af_is_broken
  • af_is_not_broken
  • bring_works_inline_with_pcdm
  • bump_deriv
  • bump_version
  • bumpdep
  • characterization
  • clarify_error_message_259
  • config
  • contained_files
  • coverage
  • coverage_extraction
  • derivatives_spec_refactor
  • document_schema_predicates
  • dont_send
  • drop_prefix
  • fileset_typo
  • fix-110
  • fix/virus_check
  • fix_149_rework_parent_child
  • fix_156_optimize_tests
  • fix_build_131
  • fix_multiple_types
  • fix_rubocop
  • fix_types
  • gen_extracted_text_service
  • homepage
  • hp-0.0.1
  • hw-file
  • hydra-derivatives-3
  • improved_versioning
  • is_af_broken
  • issue_109
  • java8
  • jcoyne-patch-1
  • jetty_rake_task
  • local_file
  • master
  • move_generic_file_service
  • move_rdf_vocab
  • namespace_refactor
  • namespace_vocabs
  • namespaces
  • new_ordering
  • new_services_for_removing
  • new_vs_create
  • no_ordered_files
  • ordered_members_only
  • parent_becomes_in
  • performance_testing
  • persist_derivatives_service
  • readme-jetty
  • reducing-method-length-violations
  • refactor_add_file
  • refactor_logic
  • remove-af-ag
  • remove-hydra-collections
  • remove_deprecation
  • remove_extra_space
  • remove_extraneous_self
  • remove_filters
  • remove_from_collections
  • remove_from_works
  • remove_fulltext
  • remove_thumbnail
  • removed_file_format
  • rework_getters
  • rm_deprecated_classes
  • rm_related_tests
  • rubocop_autocorrect_rspec
  • rubocop_exclude
  • rubocopped
  • services
  • spec_helper_deprecation
  • test_generic_work_subclass
  • thumbnail
  • tightening-up-dependencies
  • unordered_collections
  • update_derivatives
  • update_hydra_pcdm
  • update_rubocop
  • upload_file_to_gfile
  • use_logger
  • v0.0.1
  • v0.1.0
  • v0.10.0
  • v0.11.0
  • v0.3.0
  • v0.4.0
  • v0.5.0
  • v0.6.0
  • v0.7.0
  • v0.7.1
  • v0.8
  • v0.8.1
  • v0.9.0
  • validate_collection_membership
  • validation_in_add_file_service
  • validations
  • versioning_handled_by_parameters
  • virus
  • work
  • workaround_AT_shift

pending completion
713

push

travis-ci

jeremyf
Extracting VirusCheckService from module mixin

One of the major disadvantages of module mixins is that several methods
often get defined on the object. This greatly increases the chance of
method collisions if lots of mixins are used.

So, while preserving much of the outward interface of the
`Hydra::Works::VirusCheck`'s validation, I'm extracting a collaborating
class that can do the heavy lifting against the file.

This involved a bit of additional refactoring as I was encountering
challenges with ClamAV definitions. By relying also on dependency
injection of the system virus scanner, I can more easily test each
piece of the anti-virus process in better isolation.

642 of 648 relevant lines covered (99.07%)

32.25 hits per line

Relevant lines Covered
Build:
Build:
648 RELEVANT LINES 642 COVERED LINES
32.25 HITS PER LINE
Source Files on extracting-collaborating-class
  • List 0
  • Changed 0
  • Source Changed 0
  • Coverage Changed 0
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
713 extracting-collaborating-class Extracting VirusCheckService from module mixin One of the major disadvantages of module mixins is that several methods often get defined on the object. This greatly increases the chance of method collisions if lots of mixins are used. So, while ... push 07 May 2016 03:12AM UTC jeremyf travis-ci pending completion  
711 extracting-collaborating-class Extracting VirusCheckService from module mixin One of the major disadvantages of module mixins is that several methods often get defined on the object. This greatly increases the chance of method collisions if lots of mixins are used. So, while ... push 07 May 2016 03:10AM UTC jeremyf travis-ci pending completion  
709 extracting-collaborating-class Extracting VirusCheckService from module mixin One of the major disadvantages of module mixins is that several methods often get defined on the object. This greatly increases the chance of method collisions if lots of mixins are used. So, while ... push 06 May 2016 02:05PM UTC jeremyf travis-ci pending completion  
See All Builds (589)
  • Repo on GitHub
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc