• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

projecthydra-labs / hydra-works / 709
99%
master: 99%

Build:
Build:
LAST BUILD BRANCH: v0.11.0
DEFAULT BRANCH: master
Ran 06 May 2016 02:05PM UTC
Jobs 1
Files 33
Run time 3s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
709

push

travis-ci

jeremyf
Extracting VirusCheckService from module mixin

One of the major disadvantages of module mixins is that several methods
often get defined on the object. This greatly increases the chance of
method collisions if lots of mixins are used.

So, while preserving much of the outward interface of the
`Hydra::Works::VirusCheck`'s validation, I'm extracting a collaborating
class that can do the heavy lifting against the file.

This involved a bit of additional refactoring as I was encountering
challenges with ClamAV definitions. By relying also on dependency
injection of the system virus scanner, I can more easily test each
piece of the anti-virus process in better isolation.

41 of 41 new or added lines in 3 files covered. (100.0%)

639 of 648 relevant lines covered (98.61%)

32.24 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
3
100.0
lib/hydra/works/models/concerns/file_set/virus_check.rb
Jobs
ID Job ID Ran Files Coverage
1 709.1 (2.2) 06 May 2016 02:05PM UTC 0
98.61
Travis Job 709.1
Source Files on build 709
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #709
  • a21f617f on github
  • Next Build on extracting-collaborating-class (#711)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc